Improve py27 detection to avoid "No module named venv" when using plonecli

[idgserpro]

• Plone CLI version: 2.1.2
• Python version: 2.7
• Operating System: Ubuntu 18.04

Right now, the logic to use virtualenv instead of venv is a bit fragile, since it tries to detect python 2 by comparing if the bin is python2.7

plonecli/plonecli/cli.py

Line 120 in b478678

if python_bin == "python2.7":

A more robust condition using sys.version_info is better since you can use any compiled python in any path. A little hackish, but it works instead of comparing to python2.7string: if subprocess.call([python_bin, "-c", "import sys; sys.exit(0) if sys.version_info.major == 2 else sys.exit(1)"]) == 0

@jensens

[jensens]

@idgserpro sounds like a plan. Would you prepare a pull request?
Alternatively checking python --version would be a way to check. But executing code with an exit is probably most save.

[idgserpro]

I thought about the PR but can't sign the Contributor's Agreement and this package it's in plone namespace. 😢 That's why it's opened as an issue with a suggestion.

[MrTango]

I thought about the PR but can't sign the Contributor's Agreement

why?

I's a pity, you have a lot great ideas ;)