From 51140f9dbbd9c3f8a2baea76df086f971c9c3596 Mon Sep 17 00:00:00 2001
From: MrTango <md@derico.de>
Date: Tue, 22 Apr 2025 20:51:54 +0300
Subject: [PATCH] fix tests for new image sizes attribute

---
 news/180.bugfix                                    | 2 ++
 plone/outputfilters/tests/test_picture_variants.py | 8 ++++----
 2 files changed, 6 insertions(+), 4 deletions(-)
 create mode 100644 news/180.bugfix

diff --git a/news/180.bugfix b/news/180.bugfix
new file mode 100644
index 0000000..5e96353
--- /dev/null
+++ b/news/180.bugfix
@@ -0,0 +1,2 @@
+allow sizes attribute in picture tags, see https://github.com/plone/plone.namedfile/pull/180
+[MrTango]
diff --git a/plone/outputfilters/tests/test_picture_variants.py b/plone/outputfilters/tests/test_picture_variants.py
index 8e8d074..ffbedac 100644
--- a/plone/outputfilters/tests/test_picture_variants.py
+++ b/plone/outputfilters/tests/test_picture_variants.py
@@ -173,7 +173,7 @@ def test_parsing_long_doc(self):
 <p class="discreet">
     <picture>
         <source
-            srcset="resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w"/>
+             sizes="(min-width: 576px) 400px, (min-width: 768px) 600px, 98vw" srcset="resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w"/>
         <img alt="" class="image-richtext image-inline image-size-small" data-linktype="image"
             data-picturevariant="small" data-scale="preview" data-val="{uid}" loading="lazy"
             src="resolveuid/{uid}/@@images/image/preview"/>
@@ -190,7 +190,7 @@ def test_parsing_long_doc(self):
 <p>
     <picture class="captioned">
         <source
-            srcset="resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/great 1200w"/>
+             sizes="(min-width: 576px) 600px, 98vw" srcset="resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/great 1200w"/>
         <img alt="" class="image-richtext image-left image-size-medium captioned zoomable" data-linktype="image"
             data-picturevariant="medium" data-scale="larger" data-val="{uid}" loading="lazy"
             src="resolveuid/{uid}/@@images/image/teaser"/>
@@ -205,7 +205,7 @@ def test_parsing_long_doc(self):
 <p class="discreet">
     <picture>
         <source
-            srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
+             sizes="(min-width: 576px) 1000px, 98vw" srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
         <img alt="" class="image-richtext image-right image-size-large" data-linktype="image"
             data-picturevariant="large" data-scale="huge" data-val="{uid}" loading="lazy"
             src="resolveuid/{uid}/@@images/image/larger"/>
@@ -216,7 +216,7 @@ def test_parsing_long_doc(self):
 <h2>
     <picture>
         <source
-            srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
+             sizes="(min-width: 576px) 1000px, 98vw" srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
         <img alt="" class="image-richtext image-inline image-size-large" data-linktype="image"
             data-picturevariant="large" data-scale="huge" data-val="{uid}" loading="lazy"
             src="resolveuid/{uid}/@@images/image/larger"/>