TinyMCE settings are outdated

[szakitibi]

Plone 6.1 switched to TinyMCE 7 version and plone/Products.CMFPlone#3954 stated:

All done. We will point here from the roadmap document.

In mockup (plone.staticresources) there is temporary JS patch (see plone/mockup@eac9e4b and here), with comment:

        // BBB: TinyMCE 6 has renamed toolbar and menuitem plugins.Add commentMore actions
        // map them here until they are updated in Plone's configuration:

while TinyMCE settings are outdated still using the TinyMCE 5 values:

plone.base/src/plone/base/interfaces/controlpanel.py

Line 630 in 3aa2941

"superscript subscript | formats | removeformat",

plone.base/src/plone/base/interfaces/controlpanel.py

Line 665 in 3aa2941

default="ltr rtl | undo redo | styleselect | bold italic | "

[szakitibi]

Additionally a few plugins got removed with TinyMCE 6 - see docs https://www.tiny.cloud/docs/tinymce/6/migration-from-5x/#removed-plugins, namely: fullpage, tabfocus, hr, noneditable, paste, print.

These plugins are still listed as options in the controlpanel due to being listed in the plugins vocabulary:

plone.base/src/plone/base/interfaces/controlpanel.py

Lines 528 to 574 in 3aa2941

	plugins = schema.List(
	title=_("label_tinymce_plugins", default="Editor plugins"),
	description=_(
	"help_tinymce_plugins", default=("Select plugins to include with tinymce")
	),
	value_type=schema.Choice(
	vocabulary=SimpleVocabulary(
	[
	SimpleTerm("accordion", "accordion", "accordion"),
	SimpleTerm("advlist", "advlist", "advlist"),
	SimpleTerm("anchor", "anchor", "anchor"),
	SimpleTerm("autolink", "autolink", "autolink"),
	SimpleTerm("autosave", "autosave", "autosave"),
	SimpleTerm("charmap", "charmap", "charmap"),
	SimpleTerm("code", "code", "code"),
	SimpleTerm("colorpicker", "colorpicker", "colorpicker"),
	SimpleTerm("contextmenu", "contextmenu", "contextmenu"),
	SimpleTerm("directionality", "directionality", "directionality"),
	SimpleTerm("emoticons", "emoticons", "emoticons"),
	SimpleTerm("fullpage", "fullpage", "fullpage"),
	SimpleTerm("fullscreen", "fullscreen", "fullscreen"),
	SimpleTerm("help", "help", "help"),
	SimpleTerm("hr", "hr", "hr"),
	SimpleTerm("insertdatetime", "insertdatetime", "insertdatetime"),
	SimpleTerm("layer", "layer", "layer"),
	SimpleTerm("lists", "lists", "lists"),
	SimpleTerm("media", "media", "media"),
	SimpleTerm("nonbreaking", "nonbreaking", "nonbreaking"),
	SimpleTerm("noneditable", "noneditable", "noneditable"),
	SimpleTerm("pagebreak", "pagebreak", "pagebreak"),
	SimpleTerm("paste", "paste", "paste"),
	SimpleTerm("preview", "preview", "preview"),
	SimpleTerm("print", "print", "print"),
	# XXX disable save button since it is not implemented
	# SimpleTerm('save', 'save', u'save'),
	SimpleTerm("searchreplace", "searchreplace", "searchreplace"),
	SimpleTerm("tabfocus", "tabfocus", "tabfocus"),
	SimpleTerm("table", "table", "table"),
	SimpleTerm("textcolor", "textcolor", "textcolor"),
	SimpleTerm("textpattern", "textpattern", "textpattern"),
	SimpleTerm("template", "template", "template"),
	SimpleTerm("visualblocks", "visualblocks", "visualblocks"),
	SimpleTerm("visualchars", "visualchars", "visualchars"),
	SimpleTerm("wordcount", "wordcount", "wordcount"),
	]
	)
	),

The only reason why these are not resulting errors, is the filtering in current tinymce implementation validating plugins.

[szakitibi]

Note: The menubar value has been already fixed with #83.

[szakitibi]

Found another TinyMCE setting patched (hardcoded) in plone.staticresources (mockup) for licence_key.

[szakitibi]

There is also the confusing case of the TinyMCE 7 template plugin. Currently if it is enabled in Classic UI Demo 6.1.2 it shows the following warning in console:

https://www.tiny.cloud/docs/tinymce/7/migration-from-6x/#removed-plugins-template-plugin

However the opensource template plugin seems to just work fine. The templates "stamp" icon can be enabled in the toolbar with ... | template | ... and the templates can be defined and inserted in the editor.

Does TinyMCE 7 force users to use the paid templates plugin (previously advtemplate) instead of the open-source template plugin a morally questionable way? Does Plone 6.1.2 have the open-source template plugin included in plone.staticresources or it will break with TinyMCE version 8?

[szakitibi]

Does Plone 6.1.2 have the open-source template plugin included in plone.staticresources or it will break with TinyMCE version 8?

Found the answer here plone/mockup@0211093 and here https://github.com/plone/mockup/blob/253d77a91ac159c2c57c75eda129d9d2aabaf4df/src/pat/tinymce/tinymce--implementation.js#L180. So there is a backport for the template plugin, however there is nothing there for the other removed plugins currently being removed by the JS validation. The list of configurable plugins which are currently broken and hidden by the JS fix only are:

['colorpicker',
'contextmenu',
'fullpage',
'hr',
'layer',
'noneditable',
'paste',
'print',
'tabfocus',
'textcolor',
'textpattern']

There are a few plugins which are not mentioned in https://www.tiny.cloud/docs/tinymce/6/migration-from-5x/#removed-plugins, so probably got removed erlier.