From 3084b1536eb4bf9260937211faca4e87c48b537e Mon Sep 17 00:00:00 2001 From: Maurits van Rees Date: Mon, 23 May 2022 11:38:02 +0200 Subject: [PATCH] Add GitHub action to test PR on coredev. This is a gitHub Action for testing a package PR on buildout.coredev. For now (May 2022) it is an experiment, but I think we need it. Reasons: 1. The robot tests on Jenkins are flaky/unstable, which most likely is due to several robot jobs running parallel on one node. 2. Python 3.10 is not working with the 'Python Shining Pandas' plugin we use on Jenkins. We had it running with a different script for a while, but these changes got lost. Should be restorable, but let's try GHA. One thing to watch out for, is that robot tests are not always reported as failures. On the one hand there is config for that on Jenkins: https://github.com/plone/jenkins.plone.org/issues/297 On the other hand I see the same problem locally: https://github.com/plone/Products.CMFPlone/issues/3537 But those two problems seem solved by now (June 2022). We use a reusable workflow in [`plone/.github`](https://github.com/plone/.github/blob/main/reusable-workflows/coredev.yml). Aftwerwards, we could install it in all relevant Plone repos using https://github.com/asottile/all-repos But nothing too hasty. :-) --- .github/workflows/coredev-60.yml | 7 +++++++ news/3540.bugfix | 3 +++ 2 files changed, 10 insertions(+) create mode 100644 .github/workflows/coredev-60.yml create mode 100644 news/3540.bugfix diff --git a/.github/workflows/coredev-60.yml b/.github/workflows/coredev-60.yml new file mode 100644 index 0000000000..06b78719b3 --- /dev/null +++ b/.github/workflows/coredev-60.yml @@ -0,0 +1,7 @@ +# This is a GitHub Action for testing a PR of the current package on buildout.coredev. +# See https://github.com/plone/.github/blob/main/.github/workflows/coredev-60.yml +name: Test PR on buildout.coredev 6.0 +on: pull_request +jobs: + test-coredev: + uses: plone/.github/.github/workflows/coredev-60.yml@main diff --git a/news/3540.bugfix b/news/3540.bugfix new file mode 100644 index 0000000000..2db6706af6 --- /dev/null +++ b/news/3540.bugfix @@ -0,0 +1,3 @@ +Run all robot tests and all Py 3.10 tests on GitHub Actions. +Uses a new reusable workflow. +[maurits]