Recycle bin: can't delete an item again after it was restored

[davisagli]

This is a bug found while testing #4168.

Steps to reproduce:

1. Add a new page "page 1"
2. Delete "page 1" via the Actions menu -> Delete
3. In the "Do you really want to delete this item?" dialog, click the Delete button to confirm.
4. In the recycle bin, restore "page 1"
5. Try again to delete "page 1" via the Actions menu -> Delete

Expected: It should be possible to delete the item again.
Actual: an info message is shown ("page 1" has already been deleted) and it is not deleted.

Interestingly, deleting the page at this point via the Contents view works fine.

[rohnsha0]

@davisagli was able to reproduce...

[rohnsha0]

and strangely if we restart the server, it works again as expected...
is there something caused due to some expiration of tokens?

[rohnsha0]

@davisagli I am unable to understand what might have gone wrong... IMO this is due to some legacy plone code?! not sure tho

[davisagli]

@rohnsha0 I'm not sure, I'll try to take a closer look.

[davisagli]

@rohnsha0 Fixed in be104f9