Skip to content

ScaleManager depends on "if (Null)" for isFullScreen #15

@ghost

Description

In Dart, if (Null) and if (!Null) cause type errors.

ScaleManager depends on !isFullScreen evaluating like isFullScreen == Null in at least one line of code.

If the following lines of code are placed in the preload() method for a State implementer:

game.scale.scaleMode = ScaleManager.SHOW_ALL;
game.scale.setScreenSize(false);

A type error occurs at line 1108 in scale_manager.dart:
} else if (!this.isFullScreen) {

isFullScreen should probably be initialized to false.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions