-
Notifications
You must be signed in to change notification settings - Fork 0
Development #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Development #36
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
56e44f8
pop up mode and chat buble toggle
pladisdev 82db2b0
potential audio fix
pladisdev 579683d
linux sh and better docker support
pladisdev fad6d1a
fixed linux build?
pladisdev a12de82
linux fix part 2
pladisdev 5d79afe
docker fix part 1
pladisdev 0f3af89
Initial plan
Copilot d5d90f6
Initial plan
Copilot cbf5fcd
Initial plan
Copilot 5a5d1d5
Initial plan
Copilot 207ba9b
Initial plan
Copilot 76b9912
Initial plan
Copilot 366b640
Initial plan
Copilot ebc7bb7
Update frontend/src/pages/YappersPage.jsx
pladisdev be9a086
Initial plan
Copilot 3fc9146
Update frontend/src/pages/YappersPage.jsx
pladisdev 914b789
Replace sys.platform with platform.system() for OS detection
Copilot 938886f
Fix race condition in popup avatar lifecycle
Copilot 7737a2f
Extract magic numbers to named constants for better readability
Copilot 3ea0d45
Extract magic number -2.5px into avatarActiveOffset setting
Copilot ee4de2a
Fix audio cleanup in popup mode when play() fails
Copilot 3ae0527
Merge pull request #17 from pladisdev/copilot/sub-pr-8-bf786502-ac5d-…
pladisdev 25dc303
Extract hex opacity calculation to utility function
Copilot 730dc88
Fix audio error handlers to clean up tracking references
Copilot bb266bd
Merge pull request #16 from pladisdev/copilot/sub-pr-8-4be2dd0e-06ec-…
pladisdev 7d70a13
Merge pull request #15 from pladisdev/copilot/sub-pr-8-9e407134-0238-…
pladisdev d1f450d
Merge pull request #14 from pladisdev/copilot/sub-pr-8-please-work
pladisdev 5436727
Merge pull request #13 from pladisdev/copilot/sub-pr-8-one-more-time
pladisdev d8c850e
Merge pull request #12 from pladisdev/copilot/sub-pr-8-yet-again
pladisdev 1405787
Merge pull request #11 from pladisdev/copilot/sub-pr-8-another-one
pladisdev 1ad53b1
Merge pull request #10 from pladisdev/copilot/sub-pr-8-again
pladisdev 3956aed
Merge branch 'main' into development
pladisdev a0b1f82
update flow for builds
pladisdev a2d0cea
Merge branch 'main' into development
pladisdev 6adf5b1
better build and release file
pladisdev 57df8ef
workflow fix
pladisdev 6bbabff
Merge branch 'main' into development
pladisdev 7672520
build fix
pladisdev d56e12e
Merge branch 'development' of https://github.com/pladisdev/chat-yappe…
pladisdev 5aca8cf
Merge branch 'main' into development
pladisdev f0cb455
usernames in chat bubbles
pladisdev dd0ffab
Merge branch 'development' of https://github.com/pladisdev/chat-yappe…
pladisdev 4f534c8
twitch authentifcation
pladisdev 9095db5
Merge branch 'main' into development
pladisdev 979acca
tts limit
pladisdev 008f0e0
notifcation that user needs to click page, quick status
pladisdev c09bdcc
update readme, version
pladisdev 1cb53f6
Merge branch 'main' into development
pladisdev ee60426
emergency twitch fix
pladisdev 56967e2
Merge branch 'main' into development
pladisdev cfcf2dd
Merge branch 'main' into development
pladisdev 1aa6813
yep
pladisdev 5844084
dang
pladisdev 4a6a8e5
better twitch logging
pladisdev 693bfbc
animations and avatar layout editor
pladisdev 326928e
fix spin animation
pladisdev a80e583
twitch fix part 2
pladisdev 69800d3
Merge branch 'main' into development
pladisdev 365ef8e
twitch fix, better fonts, cleanup
pladisdev 61d9dcf
Merge branch 'main' into development
pladisdev 046c52f
fixed imports
pladisdev 7b33d13
fixed things
pladisdev 638fb4e
Merge branch 'main' into development
pladisdev 59a7722
undefined fix
pladisdev 4a09f0b
twitch test fix
pladisdev 99b9642
another mock fix
pladisdev 15efb3c
another fix for twitch creds tests
pladisdev 6ca3832
better logging
pladisdev 08355e7
twitch fixes?
pladisdev 0d7bb86
another twitch fix
pladisdev 484caaf
Merge branch 'main' into development
pladisdev a45dcfc
fix twitch io 3.x
pladisdev 478e8ea
Merge branch 'development' of https://github.com/pladisdev/chat-yappe…
pladisdev 6ad992d
fix pipelines for python to use 3.10
pladisdev 2fcaa47
Merge branch 'main' into development
pladisdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,10 +23,10 @@ jobs: | |
| with: | ||
| fetch-depth: 0 # Fetch all history for proper versioning | ||
|
|
||
| - name: Set up Python 3.11 | ||
| - name: Set up Python 3.10 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11' | ||
| python-version: '3.10' | ||
| cache: 'pip' | ||
|
|
||
| - name: Set up Node.js | ||
|
|
@@ -412,10 +412,10 @@ jobs: | |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Python 3.11 | ||
| - name: Set up Python 3.10 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11' | ||
| python-version: '3.10' | ||
|
Comment on lines
+415
to
+418
|
||
| cache: 'pip' | ||
|
|
||
| - name: Set up Node.js | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ['3.9', '3.10', '3.11'] | ||
| python-version: ['3.10'] | ||
|
||
|
|
||
| steps: | ||
| - name: Checkout code | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -331,9 +331,15 @@ async def event_ready(self): | |||
| who = getattr(self, "nick", None) or self._nick or "unknown" | ||||
| try: | ||||
| logger.info(f"Twitch bot ready as {who}, listening to {self.channel_name}") | ||||
| # Join the channel to start receiving messages (required in TwitchIO 3.x) | ||||
| await self.join_channels([self.channel_name]) | ||||
| logger.info(f"Joined channel: {self.channel_name}") | ||||
|
|
||||
| # In TwitchIO 3.x, channels from initial_channels should auto-join | ||||
| # But we can verify by checking connected channels | ||||
| if hasattr(self, 'connected_channels'): | ||||
| logger.info(f"Connected channels: {list(self.connected_channels)}") | ||||
|
|
||||
| # Log available methods for debugging | ||||
| logger.debug(f"Bot methods: {[m for m in dir(self) if 'channel' in m.lower() or 'join' in m.lower()]}") | ||||
|
||||
| logger.debug(f"Bot methods: {[m for m in dir(self) if 'channel' in m.lower() or 'join' in m.lower()]}") |
Comment on lines
+335
to
+342
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modified event_ready method now relies on TwitchIO's automatic channel joining behavior instead of explicitly calling join_channels(). This behavioral change lacks test coverage. Consider adding a test to verify that:
- Channels specified in
initial_channelsare automatically joined - The
connected_channelsattribute is properly populated after the bot is ready - The bot can successfully receive messages from the auto-joined channel
This is especially important given the comment mentions this is a TwitchIO 3.x-specific behavior that should be verified.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change downgrades the Python version from 3.11 to 3.10, which is inconsistent with the project's stated requirements. The README.md specifies "Python 3.9+" (line 130). If Python 3.10 is specifically required for the build process, the documentation should be updated to clarify this. Otherwise, consider using Python 3.11 to align with the latest stable version and ensure forward compatibility.