wxLua crashes host app

[DBM89]

I passed parameter -DwxLuaBind_COMPONENTS="core;base" and I get wx.dll. dumpbin declares that wx.dll has 5 dependencies, base, core, aui, html and net.
I'm able to write a Lua script and I get the widgets I want, but issue is when it comes to closing.
In BizHawk emulator, I launch the Lua Console and run the script, when I close the Lua console window, the app gets shut down.
In DesMume emulator, I launch the Lua Console and run the script, when the script ends the app gets shut down.
Same thing happens in mGBA Lua console and i click on Reset.

Bizhawk uses Lua 5.4 and DesMume uses Lua 5.1, issue is present when compiling against WxWidgets 3.2.7. WxWidgets 3.3 master from GitHub gave me compilation errors, I commented out the functions until i successfully compiled against 3.3, but issue is still there, I think issue lies with wxLua.
I'm using C ffi for Lua to import the DLLs since standard Lua doesn't have ffi.
Just having wx = require "wx" in the script is enough to shut app down when script finishes

So questions are as followed

1. Has wxLua been coded to forceibly close the host app when internal host Lua console is reset / Closed?
2. According to the WxWidgets blog 3.3 stable will be release soon, is wxLua still being updated?
3. I haven't tried a static build since everything works, apart from ending, is there any benefits if I use a static build?

[pkulchenko]

@DBM89, the issue with the compilation against (upcoming) wxWidgets v3.3 is related to wxpropgrid changes that haven't been incorporated into wxlua yet. See #124 for details (you may have to use 3.2.2.x or disable wxpropgrid compilation).

Has wxLua been coded to forceibly close the host app when internal host Lua console is reset / Closed?

Not directly, but it does call wxTheApp->SetExitOnFrameDelete(true); in luaopen_wx (luamodule.cpp), which may have the effect that you observe if all application windows are closed.

According to the WxWidgets blog 3.3 stable will be release soon, is wxLua still being updated?

Yes; right now it doesn't support 3.3 until the interface is updated (as described above). I will likely wait for the release to be out.

I haven't tried a static build since everything works, apart from ending, is there any benefits if I use a static build?

I don't think you get a different behavior from a static build.

If you do want to incorporate wxApp::CleanUp to see if this helps with your issue, a good place for it is likely to be the reportShutdown function. Try applying the following diff:

diff --git a/wxLua/modules/luamodule/luamodule.cpp b/wxLua/modules/luamodule/luamodule.cpp
index e6f8242..12803a7 100644
--- a/wxLua/modules/luamodule/luamodule.cpp
+++ b/wxLua/modules/luamodule/luamodule.cpp
@@ -212,6 +212,8 @@ extern "C" {
     static int reportShutdown(lua_State *L)
     {
         s_wxlState.CloseLuaState(true, false);
+        wxTheApp->OnExit();
+        wxTheApp->CleanUp();
         return 0;
     }
 }

If none of this helps and you still want to use wxlua as part of your application, I'd consider not closing the state and simply running your Lua code using loadstring/load functions.

[DBM89]

Unfortunately, Your suggestion hasn't work. I put a printf statement in reportShutdown and nothing appeared in the terminal, that function isn't being executed
I placed printf statements in other places in the codebase, I can confirm that the below is being executed.

wxLuaStateRefData::~wxLuaStateRefData
if (m_own_stateData) delete m_wxlStateData;

wxLuaStateData::~wxLuaStateData

Are you able to suggest any other places to put the requested wxWidget function?

[DBM89]

I made the following change and no crashes so thanks for providing suggestions
case DLL_PROCESS_DETACH : wxLuaModule_hDll = NULL; wxTheApp->OnExit(); wxTheApp->CleanUp();

I still get the below error, but error points to issue being on wxWidgets side so will ask them about it
wxWidgets-3.3.0\src\msw\utils.cpp(1686): 'RegisterClass() in wxCreateHiddenWindow' failed with error 0x00000582 (Class already exists.).

I hope you are able to get wxLua to work correctly with recently release version 3.3.0 since I had to comment out bits of code in wxLua that flagged errors.

[pkulchenko]

case DLL_PROCESS_DETACH : wxLuaModule_hDll = NULL; wxTheApp->OnExit(); wxTheApp->CleanUp();

That's interesting; thank you for the suggestion!

I still get the below error, but error points to issue being on wxWidgets side so will ask them about it
wxWidgets-3.3.0\src\msw\utils.cpp(1686): 'RegisterClass() in wxCreateHiddenWindow' failed with error 0x00000582 (Class already exists.).

Let me know what you hear back on this.

I hope you are able to get wxLua to work correctly with recently release version 3.3.0 since I had to comment out bits of code in wxLua that flagged errors.

I don't have time to apply the changes at the moment, but will review and incorporate updates that someone provides for this issue.
Also, you should be able to add -DCMAKE_CXX_FLAGS="-DwxLUA_USE_wxPropertyGrid=0" to cmake call to disable wxPropertyGrid usage (and related errors).

[DBM89]

All I'm interested is in the base and core libraries, I had to comment stuff out from the 3 below files for successful compilation against 3.3.0
wxbase_data.cpp
wxcore_gdi.cpp
wxcore_image.cpp

On wxWidgets, I raised below ticket
wxWidgets/wxWidgets#25550
Vadz says to use wxInitialize() and wxUninitialize() along with wxIMPLEMENT_APP.
You're already using IMPLEMENT_ABSTRACT_CLASS and IMPLEMENT_APP_NO_MAIN, I have no idea what needs to be replaced.
Whatever I try just leads to luamodule.cpp and missing dependencies errors

I'm not an expert when it comes to CPP, you're busy so I'm just going to leave this one until you have time to look at it

[DBM89]

  case DLL_PROCESS_DETACH : wxLuaModule_hDll = NULL; wxEntryCleanup();

I have found making the above modification fixes the issue.
The code is using IMPLEMENT_APP_NO_MAIN macro, which uses wxEntryStart
wxUninitialize() doesn't work since wxInitialize() isn't used to begin with.
wxUninitialize() function uses wxEntryCleanup() so using this function when DLL_PROCESS_DETACH cleans everything up and when dll is reused, no crashes