Skip to content

Closes #41: externaltask request_error_details does not use same requests session as other calls #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeaudio wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Closes #41: externaltask request_error_details does not use same requests session as other calls #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions pycamunda/externaltask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Get(pycamunda.base.CamundaRequest):

id_ = PathParameter('id')

def __init__(self, url: str, id_: str, request_error_details: bool = True):
def __init__(self, url: str, id_: str, request_error_details: bool = False):
"""Query for an external task.

:param url: Camunda Rest engine URL.
Expand All @@ -117,7 +117,15 @@ def __call__(self, *args, **kwargs) -> ExternalTask:
if self.request_error_details:
if external_task.error_details is None:
try:
response = requests.get(self.url + '/errorDetails')
_request = None
request_data = {}
if self.session is not None:
_request = self.session
else:
_request = requests
if self.auth is not None:
request_data['auth'] = self.auth
response = requests.get(self.url + '/errorDetails', **request_data)
except requests.exceptions.RequestException:
raise pycamunda.PyCamundaException()
if not response:
Expand Down Expand Up @@ -193,7 +201,7 @@ def __init__(
ascending: bool = True,
first_result: int = None,
max_results: int = None,
request_error_details: bool = True
request_error_details: bool = False
):
"""Query for a list of external tasks using a list of parameters. The size of the result set
can be retrieved by using the Get Count request.
Expand Down Expand Up @@ -266,7 +274,15 @@ def __call__(self, *args, **kwargs) -> typing.Tuple[ExternalTask]:
for external_task in external_tasks:
if external_task.error_details is None:
try:
response = requests.get(self.url + f'/{external_task.id_}/errorDetails')
_request = None
request_data = {}
if self.session is not None:
_request = self.session
else:
_request = requests
if self.auth is not None:
request_data['auth'] = self.auth
response = _request.get(self.url + f'/{external_task.id_}/errorDetails', **request_data)
except requests.exceptions.RequestException:
raise pycamunda.PyCamundaException()
if not response:
Expand Down