From b7489c75c0191e0addf5c4b8be5b4d0dec38c5e1 Mon Sep 17 00:00:00 2001 From: "ivan.kapustin" Date: Mon, 14 Aug 2023 02:34:49 +0300 Subject: [PATCH] fix/request_error_details_dont_use_auth --- pycamunda/externaltask.py | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/pycamunda/externaltask.py b/pycamunda/externaltask.py index 02eb959..25aaa15 100644 --- a/pycamunda/externaltask.py +++ b/pycamunda/externaltask.py @@ -97,7 +97,7 @@ class Get(pycamunda.base.CamundaRequest): id_ = PathParameter('id') - def __init__(self, url: str, id_: str, request_error_details: bool = True): + def __init__(self, url: str, id_: str, request_error_details: bool = False): """Query for an external task. :param url: Camunda Rest engine URL. @@ -117,7 +117,15 @@ def __call__(self, *args, **kwargs) -> ExternalTask: if self.request_error_details: if external_task.error_details is None: try: - response = requests.get(self.url + '/errorDetails') + _request = None + request_data = {} + if self.session is not None: + _request = self.session + else: + _request = requests + if self.auth is not None: + request_data['auth'] = self.auth + response = requests.get(self.url + '/errorDetails', **request_data) except requests.exceptions.RequestException: raise pycamunda.PyCamundaException() if not response: @@ -193,7 +201,7 @@ def __init__( ascending: bool = True, first_result: int = None, max_results: int = None, - request_error_details: bool = True + request_error_details: bool = False ): """Query for a list of external tasks using a list of parameters. The size of the result set can be retrieved by using the Get Count request. @@ -266,7 +274,15 @@ def __call__(self, *args, **kwargs) -> typing.Tuple[ExternalTask]: for external_task in external_tasks: if external_task.error_details is None: try: - response = requests.get(self.url + f'/{external_task.id_}/errorDetails') + _request = None + request_data = {} + if self.session is not None: + _request = self.session + else: + _request = requests + if self.auth is not None: + request_data['auth'] = self.auth + response = _request.get(self.url + f'/{external_task.id_}/errorDetails', **request_data) except requests.exceptions.RequestException: raise pycamunda.PyCamundaException() if not response: