[Feature Request] Support Domain Names for BaseIP in Settings.json

[unacro]

Currently the BindIP setting in Settings.json works perfectly when using a domain name in the format http://{custom_domain}:{BasePort}/.
However, when trying to use a domain name directly (instead of static IP addresses) in the BaseIP field, it results in an error like:

[ERROR] Failed to bind to [custom_domain]:4988 (ensure the program isn't already running, or try running as admin)

Would it be possible to extend the same support for domain names to the BaseIP configuration option as well?
(So that I can provide a persistent public domain for my friends, thereby freeing them from the troubles of weird network issues.)

BTW, Thanks for the GREAT project for all duelists!

[pixeltris]

I don't know if I ever tested it but it had domain name lookup on the client side:

YgoMaster/YgoMasterClient/ClientSettings.cs

Lines 274 to 299 in a6c25a3

	public static string ResolveIP(string nameOrIP)
	{
	string ip = nameOrIP;
	try
	{
	ip = ip.Replace("https://", string.Empty).Replace("http://", string.Empty);
	if (Uri.CheckHostName(ip) == UriHostNameType.Dns)
	{
	foreach (IPAddress address in Dns.GetHostAddresses(ip))
	{
	if (address.AddressFamily == AddressFamily.InterNetwork)
	{
	ip = address.ToString();
	if (MultiplayerLogConnectionState)
	{
	Console.WriteLine("Resolved " + nameOrIP + " to " + ip);
	}
	}
	}
	}
	}
	catch
	{
	}
	return ip;
	}

So in ClientSettings.json you put your domain name. But in Settings.json you still bind to 0.0.0.0 as it says in https://github.com/pixeltris/YgoMaster/blob/master/Docs/PvP.md#setting-it-up-on-wan

0.0.0.0 binds to all network adapters so you don't need to specify a domain name in Settings.json. Just ClientSettings.json.

[unacro]

I tried this.

---

Server config ./Data/Settings.json (as it says in docs):

{
    "BaseIP": "0.0.0.0",
    "BasePort": 4989,
    "SessionServerPort": 4988,
    "SessionServerIP": "{BaseIP}",
    "MultiplayerPvpClientConnectIP": "localhost",
    "MultiplayerPvpClientConnectPort": 0,// A value of 0 will use SessionServerPort
    "BindIP": "http://*:{BasePort}/",
    "MultiplayerEnabled": true,// [WARNING] Only use if you know what you're doing

Then running ./YgoMaster.exe, everything okay.

---

Try to start client connecting by local loopback, ./Data/ClientData/ClientSettings.json:

{
    "SupportedGameVersion": "2.5.0",
    "BaseIP": "localhost",
    "BasePort": 4989,
    "SessionServerPort": 4988,
    "SessionServerIP": "{BaseIP}",
    "ServerUrl": "http://localhost:{ProxyPort}/ygo",
    "ServerPollUrl": "http://localhost:{ProxyPort}/ygo/poll",

Connected successfully. I'm in game.

The ProxyPort is pretty confusing. So i looked up the source code, found it is client's own proxy server.
May i guess it's okay to use the local api server http://localhost:{ProxyPort}/*, right?

---

Try to start client connecting by remote server ip, ./Data/ClientData/ClientSettings.json:

{
    "SupportedGameVersion": "2.5.0",
    "BaseIP": "10.10.10.10", // The intranet ip used here is just a demonstration. The actual used is a public ip.
    "BasePort": 4989,
    "SessionServerPort": 4988,
    "SessionServerIP": "{BaseIP}",
    "ServerUrl": "http://localhost:{ProxyPort}/ygo",
    "ServerPollUrl": "http://localhost:{ProxyPort}/ygo/poll",

I made sure that

1. public server's ports are both open (bypass all firewall)

2. and remote web server set up reverse proxy (to game server on my pc) correctly.

Connected successfully. Also into game.

---

Try to start client connecting by public domain name, ./Data/ClientData/ClientSettings.json:

{
    "SupportedGameVersion": "2.5.0",
    "BaseIP": "ygo-server.example.com", // Trying to use domain instead of ip
    "BasePort": 4989,
    "SessionServerPort": 4988,
    "SessionServerIP": "{BaseIP}",
    "ServerUrl": "http://localhost:{ProxyPort}/ygo",
    "ServerPollUrl": "http://localhost:{ProxyPort}/ygo/poll",

Connected failed. I really don't know why.

Even sometimes game server just broke down, error:

[WARNING] Exception when processing message. Exception: System.Net.HttpListenerException (0x80004005): An attempt was made to operate on a nonexistent network connection.
   at System.Net.HttpRequestStream.Read(Byte[] buffer, Int32 offset, Int32 size)
   at YgoMaster.GameServer.Process(HttpListenerContext context)
 Token: (null)
Request: (null)

Unhandled exception:  System.Net.HttpListenerException: An attempt was made to operate on a nonexistent network connection.
   at System.Net.HttpResponseStream.Dispose(Boolean disposing)
   at System.IO.Stream.Close()
   at System.Net.HttpListenerResponse.Dispose(Boolean disposing)
   at System.Net.HttpListenerResponse.System.IDisposable.Dispose()
   at System.Net.HttpListenerResponse.Close()
   at YgoMaster.GameServer.Process(HttpListenerContext context)
   at YgoMaster.GameServer.<>c__DisplayClass124_1.<Start>b__2(Object x)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Actually, public ip is just working perfectly, but i still hope that it could support domain names.
Because i can't guarantee that the server ip will never change, and teaching all my friends to modify the configuration one by one is a very PAINFUL thing 😢

[pixeltris]

An attempt was made to operate on a nonexistent network connection. probably means the DNS resolved to something invalid. I just did a test and what I did was:

1. Changed this to google.com

YgoMaster/YgoMaster/Data/ClientData/ClientSettings.json

Line 3 in aceb6fa

"BaseIP": "localhost",

2. Changed this to some random value

YgoMaster/YgoMaster/Data/ClientData/ClientSettings.json

Line 9 in aceb6fa

"MultiplayerToken": "",// [WARNING] Only use this if you know what you're doing

3. Set this to true

YgoMaster/YgoMaster/Data/ClientData/ClientSettings.json

Line 15 in aceb6fa

"ShowConsole": false,

4. Set this to true

YgoMaster/YgoMaster/Data/ClientData/ClientSettings.json

Line 13 in aceb6fa

"MultiplayerLogConnectionState": false,

This logged the IP the DNS resolver found. It worked as expected for me. So I guess make sure your string is formatted correct? Or try debugging the ResolveIP function to find out why it isn't able to resolve the IP.

YgoMaster/YgoMasterClient/ClientSettings.cs

Line 289 in a6c25a3

Console.WriteLine("Resolved " + nameOrIP + " to " + ip);