From bb29a9b6fd89b689afa9be2f766b6aba5adf490a Mon Sep 17 00:00:00 2001 From: majiayu000 <1835304752@qq.com> Date: Sat, 28 Mar 2026 11:53:16 +0800 Subject: [PATCH 1/2] fix: report all golangci-lint issues regardless of diff Set filter_mode to nofilter in reviewdog/action-golangci-lint so that gofmt issues on unchanged lines are not silently skipped during PR checks. Fixes #6621 Signed-off-by: majiayu000 <1835304752@qq.com> --- .github/workflows/lint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index f3e1130763..231a26e81f 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -48,6 +48,7 @@ jobs: golangci_lint_version: ${{ env.GOLANGCI_LINT_VERSION }} golangci_lint_flags: --config ${{ github.workspace }}/.golangci.yml fail_level: error + filter_mode: nofilter # This job is used to check if the go linting is completed successfully # It is used to set as required check for the branch protection rules From 3e59c6999da55e28beab7e980c53d11b590ae520 Mon Sep 17 00:00:00 2001 From: majiayu000 <1835304752@qq.com> Date: Sat, 28 Mar 2026 12:42:47 +0800 Subject: [PATCH 2/2] fix: resolve lint issues in kubernetes_multicluster module Fix gofmt formatting in application.go and canary_test.go, and remove unused namespace param in baselineDeployment test helper. Signed-off-by: majiayu000 <1835304752@qq.com> --- .../kubernetes_multicluster/config/application.go | 1 - .../deployment/baseline_test.go | 12 ++++++------ .../deployment/canary_test.go | 1 - 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/pkg/app/pipedv1/plugin/kubernetes_multicluster/config/application.go b/pkg/app/pipedv1/plugin/kubernetes_multicluster/config/application.go index 7b6845b259..f497a7c224 100644 --- a/pkg/app/pipedv1/plugin/kubernetes_multicluster/config/application.go +++ b/pkg/app/pipedv1/plugin/kubernetes_multicluster/config/application.go @@ -55,7 +55,6 @@ type KubernetesApplicationSpec struct { // The label will be configured to variant manifests used to distinguish them. VariantLabel KubernetesVariantLabel `json:"variantLabel"` - } func (s *KubernetesApplicationSpec) UnmarshalJSON(data []byte) error { diff --git a/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/baseline_test.go b/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/baseline_test.go index e5a6815486..bf35301e98 100644 --- a/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/baseline_test.go +++ b/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/baseline_test.go @@ -35,14 +35,14 @@ import ( ) // baselineDeployment builds a pre-created baseline Deployment for test setup. -func baselineDeployment(namespace string) *unstructured.Unstructured { +func baselineDeployment() *unstructured.Unstructured { return &unstructured.Unstructured{ Object: map[string]any{ "apiVersion": "apps/v1", "kind": "Deployment", "metadata": map[string]any{ "name": "simple-baseline", - "namespace": namespace, + "namespace": "default", "labels": map[string]any{ "app": "simple", "pipecd.dev/managed-by": "piped", @@ -465,7 +465,7 @@ func TestPlugin_executeK8sMultiBaselineCleanStage(t *testing.T) { deploymentRes := schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployments"} // Pre-create the baseline deployment (simulating what K8S_BASELINE_ROLLOUT would have done). - _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment("default"), metav1.CreateOptions{}) + _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment(), metav1.CreateOptions{}) require.NoError(t, err) _, err = dynamicClient.Resource(deploymentRes).Namespace("default").Get(ctx, "simple-baseline", metav1.GetOptions{}) @@ -517,7 +517,7 @@ func TestPlugin_executeK8sMultiBaselineCleanStage_multipleTargets(t *testing.T) deploymentRes := schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployments"} for _, c := range []*cluster{clusterUS, clusterEU} { - _, err := c.cli.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment("default"), metav1.CreateOptions{}) + _, err := c.cli.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment(), metav1.CreateOptions{}) require.NoError(t, err) } @@ -571,7 +571,7 @@ func TestPlugin_executeK8sMultiBaselineCleanStage_withCreateService(t *testing.T serviceRes := schema.GroupVersionResource{Group: "", Version: "v1", Resource: "services"} // Pre-create both baseline deployment and service. - _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment("default"), metav1.CreateOptions{}) + _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment(), metav1.CreateOptions{}) require.NoError(t, err) _, err = dynamicClient.Resource(serviceRes).Namespace("default").Create(ctx, baselineService("default"), metav1.CreateOptions{}) require.NoError(t, err) @@ -626,7 +626,7 @@ func TestPlugin_executeK8sMultiBaselineCleanStage_withoutCreateService(t *testin deploymentRes := schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployments"} // Pre-create only a baseline deployment (no service). - _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment("default"), metav1.CreateOptions{}) + _, err := dynamicClient.Resource(deploymentRes).Namespace("default").Create(ctx, baselineDeployment(), metav1.CreateOptions{}) require.NoError(t, err) plugin := &Plugin{} diff --git a/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/canary_test.go b/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/canary_test.go index bf7082e73b..479e5348f7 100644 --- a/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/canary_test.go +++ b/pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/canary_test.go @@ -677,4 +677,3 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_withoutCreateService(t *testing. }) require.True(t, ok) } -