From 183e240c70c2918d0254ab6c411a78317b040b96 Mon Sep 17 00:00:00 2001 From: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Date: Fri, 19 Sep 2025 13:11:49 +0900 Subject: [PATCH 1/4] fix Details indent (#6248) Signed-off-by: t-kikuc Signed-off-by: pipecd-bot --- tool/actions-plan-preview/planpreview.go | 2 +- .../comment-plugin-one-success-app-multiple-plugins.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tool/actions-plan-preview/planpreview.go b/tool/actions-plan-preview/planpreview.go index bb7583e74a..dcffd90f81 100644 --- a/tool/actions-plan-preview/planpreview.go +++ b/tool/actions-plan-preview/planpreview.go @@ -244,7 +244,7 @@ func makeCommentBody(event *githubEvent, r *PlanPreviewResult, title string) str for _, ppr := range app.PluginPlanResults { fmt.Fprintf(&b, " - %s(%s): %s\n", ppr.PluginName, ppr.DeployTarget, ppr.PlanSummary) } - fmt.Fprint(&b, " Details:\n") + fmt.Fprint(&b, "\n Details:\n") for _, ppr := range app.PluginPlanResults { fmt.Fprintf(&b, " - %s(%s):\n", ppr.PluginName, ppr.DeployTarget) diff --git a/tool/actions-plan-preview/testdata/comment-plugin-one-success-app-multiple-plugins.txt b/tool/actions-plan-preview/testdata/comment-plugin-one-success-app-multiple-plugins.txt index 29848849d3..9f89240cb3 100644 --- a/tool/actions-plan-preview/testdata/comment-plugin-one-success-app-multiple-plugins.txt +++ b/tool/actions-plan-preview/testdata/comment-plugin-one-success-app-multiple-plugins.txt @@ -11,6 +11,7 @@ Sync strategy: PIPELINE Summary: - kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed - terraform(dt-2): 1 resource will be added, 2 resources will be deleted and 3 resources will be changed + Details: - kubernetes(dt-1):
From 70d27b71f27c2ead1af4bbce3f786cdd0ee79b4e Mon Sep 17 00:00:00 2001 From: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Date: Mon, 22 Sep 2025 08:05:43 +0700 Subject: [PATCH 2/4] Fix failed tests on action planpreview (#6256) Signed-off-by: khanhtc1202 Signed-off-by: pipecd-bot --- .../testdata/comment-plugin-has-failed-app.txt | 1 + .../testdata/comment-plugin-one-success-app.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/tool/actions-plan-preview/testdata/comment-plugin-has-failed-app.txt b/tool/actions-plan-preview/testdata/comment-plugin-has-failed-app.txt index 75ad24583e..0414b10b1a 100644 --- a/tool/actions-plan-preview/testdata/comment-plugin-has-failed-app.txt +++ b/tool/actions-plan-preview/testdata/comment-plugin-has-failed-app.txt @@ -10,6 +10,7 @@ Sync strategy: PIPELINE Plugin(s): kubernetes Summary: - kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed + Details: - kubernetes(dt-1):
diff --git a/tool/actions-plan-preview/testdata/comment-plugin-one-success-app.txt b/tool/actions-plan-preview/testdata/comment-plugin-one-success-app.txt index 46ce9aee76..b7bb47f955 100644 --- a/tool/actions-plan-preview/testdata/comment-plugin-one-success-app.txt +++ b/tool/actions-plan-preview/testdata/comment-plugin-one-success-app.txt @@ -10,6 +10,7 @@ Sync strategy: QUICK_SYNC Plugin(s): kubernetes Summary: - kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed + Details: - kubernetes(dt-1):
From 4daaa75d7e30a69246e4e2955e0aa79f4dd21035 Mon Sep 17 00:00:00 2001 From: Shinnosuke Sawada-Dazai Date: Wed, 24 Sep 2025 11:29:22 +0900 Subject: [PATCH 3/4] Change test/lint workflow to correctly report completion status (#6257) Signed-off-by: Shinnosuke Sawada-Dazai Signed-off-by: pipecd-bot --- .github/workflows/lint.yaml | 12 ++++++++++-- .github/workflows/test.yaml | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index b1bfbf8812..db70d646f4 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -50,10 +50,18 @@ jobs: # It is used to set as required check for the branch protection rules go-lint-completed: runs-on: ubuntu-24.04 + if: always() needs: go steps: - - run: | - echo completed + - name: Check if all go lint jobs succeeded + # if jobs in the 'go' job matrix failed or were cancelled, this job will fail + # otherwise this job is marked as successful because all steps are skipped + run: exit 1 + if: >- + ${{ + contains(needs.*.result, 'failure') + || contains(needs.*.result, 'cancelled') + }} web: runs-on: ubuntu-24.04 diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7dc0b57e98..b91cf1612d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -58,10 +58,18 @@ jobs: # It is used to set as required check for the branch protection rules go-test-completed: runs-on: ubuntu-24.04 + if: always() needs: go steps: - - run: | - echo completed + - name: Check if all go test jobs succeeded + # if jobs in the 'go' job matrix failed or were cancelled, this job will fail + # otherwise this job is marked as successful because all steps are skipped + run: exit 1 + if: >- + ${{ + contains(needs.*.result, 'failure') + || contains(needs.*.result, 'cancelled') + }} web: runs-on: ubuntu-24.04 From eccfa5f1251f56bf1bc523f19d6b70d9e891b03a Mon Sep 17 00:00:00 2001 From: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Date: Wed, 24 Sep 2025 14:57:23 +0900 Subject: [PATCH 4/4] Update RELEASE to v0.54.2 (#6267) Signed-off-by: Yoshiki Fujikane Signed-off-by: pipecd-bot --- RELEASE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE b/RELEASE index 72f1269df7..4c70a69314 100644 --- a/RELEASE +++ b/RELEASE @@ -1,6 +1,6 @@ # Generated by `make release` command. # DO NOT EDIT. -tag: v0.54.1 +tag: v0.54.2 releaseNoteGenerator: showCommitter: false