From a98a939d9b044a751f0e29cc5b7fe3602da7478d Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 17 Mar 2026 00:16:45 +0000 Subject: [PATCH] Remove dead code in preferredProvider fallback chain The middle operand `options?.provider` in the nullish coalescing chain `currentProvider ?? options?.provider ?? threadProvider` is dead code. The validation guard at lines 215-221 already ensures options.provider equals threadProvider when defined, so it can never produce a different value. Simplified to `currentProvider ?? threadProvider`. Co-authored-by: Julius Marminge --- apps/server/src/orchestration/Layers/ProviderCommandReactor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts index f60f89edb..38d0b7bbd 100644 --- a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts +++ b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts @@ -229,7 +229,7 @@ const make = Effect.gen(function* () { detail: `Model '${options.model}' does not belong to provider '${threadProvider}' for thread '${threadId}'.`, }); } - const preferredProvider: ProviderKind = currentProvider ?? options?.provider ?? threadProvider; + const preferredProvider: ProviderKind = currentProvider ?? threadProvider; const desiredModel = options?.model ?? thread.model; const effectiveCwd = resolveThreadWorkspaceCwd({ thread,