From fab42af65c43811473f056b79cdfd94d210e9ac1 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Mon, 16 Mar 2026 22:48:53 +0000 Subject: [PATCH] Fix dead code in content_block_stop handler and hardcoded provider names - Remove dead tool lookup in ClaudeAdapter's content_block_stop handler that retrieved an in-flight tool but never used it - Replace hardcoded provider name comparison with Schema.is(ProviderKind) in ProviderCommandReactor for type-safe exhaustiveness checking Co-authored-by: Julius Marminge --- .../orchestration/Layers/ProviderCommandReactor.ts | 11 ++++++----- apps/server/src/provider/Layers/ClaudeAdapter.ts | 4 ---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts index 0f1c423a0..76258f303 100644 --- a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts +++ b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts @@ -4,7 +4,7 @@ import { EventId, type OrchestrationEvent, type ProviderModelOptions, - type ProviderKind, + ProviderKind, type ProviderStartOptions, type OrchestrationSession, ThreadId, @@ -205,10 +205,11 @@ const make = Effect.gen(function* () { } const desiredRuntimeMode = thread.runtimeMode; - const currentProvider: ProviderKind | undefined = - thread.session?.providerName === "codex" || thread.session?.providerName === "claudeAgent" - ? thread.session.providerName - : undefined; + const currentProvider: ProviderKind | undefined = Schema.is(ProviderKind)( + thread.session?.providerName, + ) + ? thread.session.providerName + : undefined; const preferredProvider: ProviderKind | undefined = options?.provider ?? currentProvider; const desiredModel = options?.model ?? thread.model; const effectiveCwd = resolveThreadWorkspaceCwd({ diff --git a/apps/server/src/provider/Layers/ClaudeAdapter.ts b/apps/server/src/provider/Layers/ClaudeAdapter.ts index e000ba120..54f6c6bc3 100644 --- a/apps/server/src/provider/Layers/ClaudeAdapter.ts +++ b/apps/server/src/provider/Layers/ClaudeAdapter.ts @@ -1373,10 +1373,6 @@ function makeClaudeAdapter(options?: ClaudeAdapterLiveOptions) { }); return; } - const tool = context.inFlightTools.get(index); - if (!tool) { - return; - } } });