Skip to content

Task 1 incorrectly allows incorrect times to pass #94

@xeophon

Description

@xeophon

Task 1 asks for a calendar entry at Tuesday at 3pm.

The grading function contains this part:

  # Check for time (15:00 or 3pm)
  if re.search(r'DTSTART.*T15\d{4}', ics_content) or re.search(r'DTSTART.*T030000', ics_content):
      scores["time_correct"] = 1.0
  else:
      scores["time_correct"] = 0.0

r'DTSTART.*T030000' would allow (invalid) 3AM to still pass. Also, the T15\d{4} is overly permissive, allowing 15:59:59 to pass.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions