Skip to content

Be explicit with create_admin function and tables= that we're not creating them, but registering them #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
badlydrawnrob wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Be explicit with create_admin function and tables= that we're not creating them, but registering them #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/asgi/examples/starlette/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

# The `allowed_hosts` argument is required when running under HTTPS. It's
# used for additional CSRF defence.
admin = create_admin([Director, Movie], allowed_hosts=["my_site.com"])
admin = create_admin(tables=[Director, Movie], allowed_hosts=["my_site.com"])


router = Router(
Expand Down
3 changes: 2 additions & 1 deletion piccolo_admin/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,8 @@ def create_admin(
):
"""
:param tables:
Each of the tables will be added to the admin.
Each of the provided tables will be registered with the admin app and
editable/visible in the view. Tables must already exist (see Piccolo ORM).
:param forms:
For each :class:`FormConfig <piccolo_admin.endpoints.FormConfig>`
specified, a form will automatically be rendered in the user interface,
Expand Down