Compilation fails with BSEC_2.2.0.0_Generic_Release_30052022

[falste]

I followed the "How to install the extension with BSEC" readme steps. I am using BSEC_2.2.0.0_Generic_Release_30052022. Since the BSEC library name changes depending on version (see also #14), I just named the folder libbsec and changed the following files:

Click to expand

$ git diff
diff --git a/bme68xmodule.c b/bme68xmodule.c
index d43671b..999286e 100644
--- a/bme68xmodule.c
+++ b/bme68xmodule.c
@@ -18,7 +18,7 @@ uint8_t bsec_state[BSEC_MAX_STATE_BLOB_SIZE];
 uint8_t work_buffer[BSEC_MAX_WORKBUFFER_SIZE];
 uint32_t bsec_state_len = 0;
 bsec_library_return_t bsec_status = BSEC_OK;
-const char *bsec_conf_path = "BSEC_2.0.6.1_Generic_Release_04302021/config/bsec_sel_iaq_33v_4d/2021_04_29_02_51_bsec_h2s_nonh2s_2_0_6_1 .config";
+const char *bsec_conf_path = "libbsec/config/bsec_sel_iaq_33v_4d/2021_04_29_02_51_bsec_h2s_nonh2s_2_0_6_1 .config";
 FILE *bsec_conf;
 #endif

diff --git a/internal_functions.h b/internal_functions.h
index 9bc1c6e..934f109 100644
--- a/internal_functions.h
+++ b/internal_functions.h
@@ -19,8 +19,8 @@
 #include "BME68x-Sensor-API/bme68x_defs.h"

 #ifdef BSEC
-#include "BSEC_2.0.6.1_Generic_Release_04302021/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6/bsec_interface.h"
-#include "BSEC_2.0.6.1_Generic_Release_04302021/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6/bsec_datatypes.h"
+#include "libbsec/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6/bsec_interface.h"
+#include "libbsec/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6/bsec_datatypes.h"
 #endif

 /* CPP guard */
diff --git a/setup.py b/setup.py
index e41a4e3..27c66d3 100644
--- a/setup.py
+++ b/setup.py
@@ -7,7 +7,7 @@ if BSEC:
     ext_comp_args = ['-D BSEC']
     libs = ['pthread', 'm', 'rt', 'algobsec']
     lib_dirs = ['/usr/local/lib',
-                'BSEC_2.0.6.1_Generic_Release_04302021/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6']
+                'libbsec/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6']
 else:
     ext_comp_args = []
     libs = ['pthread', 'm', 'rt']
@@ -49,7 +49,7 @@ setup(name='bme68x',
       py_modules=['bme68xConstants', 'bsecConstants'],
       package_data={
           'bme68x': [
-               'BSEC_2.0.6.1_Generic_Release_04302021/config/bsec_sel_iaq_33v_4d/2021_04_29_02_51_bsec_h2s_nonh2s_2_0_6_1 .config',
+               'libbsec/config/bsec_sel_iaq_33v_4d/2021_04_29_02_51_bsec_h2s_nonh2s_2_0_6_1 .config',
           ]
       },
       headers=['BME68x-Sensor-API/bme68x.h',

Sadly, the installation still fails, mainly because BSEC_SAMPLE_RATE_HIGH_PERFORMANCE and BSEC_OUTPUT_COMPENSATED_GAS are undeclared:

Click to expand

bme68x-python-library $ sudo python3 setup.py install
running install
running bdist_egg
running egg_info
writing bme68x.egg-info/PKG-INFO
writing dependency_links to bme68x.egg-info/dependency_links.txt
writing top-level names to bme68x.egg-info/top_level.txt
reading manifest file 'bme68x.egg-info/SOURCES.txt'
writing manifest file 'bme68x.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-armv7l/egg
running install_lib
running build_py
running build_ext
building 'bme68x' extension
arm-linux-gnueabihf-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -ffile-prefix-map=/python3.9-3.9.2=. -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -ffile-prefix-map=/python3.9-3.9.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/include -I/usr/include/python3.9 -c BME68x-Sensor-API/bme68x.c -o build/temp.linux-armv7l-3.9/BME68x-Sensor-API/bme68x.o -D BSEC
arm-linux-gnueabihf-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -ffile-prefix-map=/python3.9-3.9.2=. -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -ffile-prefix-map=/python3.9-3.9.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/include -I/usr/include/python3.9 -c bme68xmodule.c -o build/temp.linux-armv7l-3.9/bme68xmodule.o -D BSEC
bme68xmodule.c:11: warning: "BSEC" redefined
   11 | #define BSEC
      |
<command-line>: note: this is the location of the previous definition
bme68xmodule.c: In function ‘bme_get_sensor_id’:
bme68xmodule.c:338:50: warning: passing argument 2 of ‘bme68x_get_regs’ from incompatible pointer type [-Wincompatible-pointer-types]
  338 |     rslt = bme68x_get_regs(BME68X_REG_UNIQUE_ID, &id_regs, len, &(self->bme));
      |                                                  ^~~~~~~~
      |                                                  |
      |                                                  uint8_t (*)[4] {aka unsigned char (*)[4]}
In file included from internal_functions.h:18,
                 from bme68xmodule.c:4:
BME68x-Sensor-API/bme68x.h:122:51: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘uint8_t (*)[4]’ {aka ‘unsigned char (*)[4]’}
  122 | int8_t bme68x_get_regs(uint8_t reg_addr, uint8_t *reg_data, uint32_t len, struct bme68x_dev *dev);
      |                                          ~~~~~~~~~^~~~~~~~
bme68xmodule.c: In function ‘bme_subscribe_gas_estimates’:
bme68xmodule.c:388:52: error: ‘BSEC_SAMPLE_RATE_HIGH_PERFORMANCE’ undeclared (first use in this function)
  388 |         requested_virtual_sensors[i].sample_rate = BSEC_SAMPLE_RATE_HIGH_PERFORMANCE;
      |                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
bme68xmodule.c:388:52: note: each undeclared identifier is reported only once for each function it appears in
bme68xmodule.c: In function ‘bme_subscribe_ai_classes’:
bme68xmodule.c:408:48: error: ‘BSEC_SAMPLE_RATE_HIGH_PERFORMANCE’ undeclared (first use in this function)
  408 |     requested_virtual_sensors[0].sample_rate = BSEC_SAMPLE_RATE_HIGH_PERFORMANCE;
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
bme68xmodule.c: In function ‘bme_bsec_process_data’:
bme68xmodule.c:820:15: warning: unused variable ‘data’ [-Wunused-variable]
  820 |     PyObject *data = PyDict_New();
      |               ^~~~
bme68xmodule.c:818:13: warning: unused variable ‘num_bsec_outputs’ [-Wunused-variable]
  818 |     uint8_t num_bsec_outputs = 0;
      |             ^~~~~~~~~~~~~~~~
bme68xmodule.c:817:19: warning: unused variable ‘bsec_outputs’ [-Wunused-variable]
  817 |     bsec_output_t bsec_outputs[BSEC_NUMBER_OUTPUTS];
      |                   ^~~~~~~~~~~~
bme68xmodule.c:740:18: warning: variable ‘inputs’ set but not used [-Wunused-but-set-variable]
  740 |     bsec_input_t inputs[BSEC_MAX_PHYSICAL_SENSOR];
      |                  ^~~~~~
bme68xmodule.c:821:1: warning: no return statement in function returning non-void [-Wreturn-type]
  821 | }
      | ^
bme68xmodule.c: In function ‘bme_get_digital_nose_data’:
bme68xmodule.c:829:20: warning: comparison of integer expressions of different signedness: ‘int64_t’ {aka ‘long long int’} and ‘uint64_t’ {aka ‘long long unsigned int’} [-Wsign-compare]
  829 |     if (time_stamp >= self->next_call)
      |                    ^~
bme68xmodule.c:1069:42: error: ‘BSEC_OUTPUT_COMPENSATED_GAS’ undeclared (first use in this function)
 1069 |                                     case BSEC_OUTPUT_COMPENSATED_GAS:
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
bme68xmodule.c: In function ‘bme_get_bsec_data’:
bme68xmodule.c:1120:20: warning: comparison of integer expressions of different signedness: ‘int64_t’ {aka ‘long long int’} and ‘uint64_t’ {aka ‘long long unsigned int’} [-Wsign-compare]
 1120 |     if (time_stamp >= self->next_call)
      |                    ^~
bme68xmodule.c:1331:34: error: ‘BSEC_OUTPUT_COMPENSATED_GAS’ undeclared (first use in this function)
 1331 |                             case BSEC_OUTPUT_COMPENSATED_GAS:
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
bme68xmodule.c: In function ‘bme_enable_gas_estimates’:
bme68xmodule.c:1587:48: error: ‘BSEC_SAMPLE_RATE_HIGH_PERFORMANCE’ undeclared (first use in this function)
 1587 |     requested_virtual_sensors[0].sample_rate = BSEC_SAMPLE_RATE_HIGH_PERFORMANCE;
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At top level:
bme68xmodule.c:737:18: warning: ‘bme_bsec_process_data’ defined but not used [-Wunused-function]
  737 | static PyObject *bme_bsec_process_data(BMEObject *self, bsec_bme_settings_t *sensor_settings, uint8_t i, int64_t time_stamp)
      |                  ^~~~~~~~~~~~~~~~~~~~~
error: command '/usr/bin/arm-linux-gnueabihf-gcc' failed with exit code 1

I guess it is ignoring the bsecConstants.py, because BSEC_SAMPLE_RATE_HIGH_PERFORMANCE is defined there, but I am not sure what the deal with BSEC_OUTPUT_COMPENSATED_GAS is.

My system:

$ uname -a
Linux raspberrypi 5.15.70-v7l+ #1590 SMP Tue Sep 27 15:58:00 BST 2022 armv7l GNU/Linux
$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 11 (bullseye)"
NAME="Raspbian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

[Blandi88]

Just received my bme688 breakout board and I have this same exact problem with the newest version of bsec. Spent hours trying to fix it.

BSEC_SAMPLE_RATE_HIGH_PERFORMANCE
BSEC_OUTPUT_COMPENSATED_GAS

^these have been removed from the integration manual completely. Luckily I was able to get bsec 2.0.6.1 from the “deleted” field in this repo. Bsec 2.0.6.1 compiled like a charm.

[cpietsch]

any news on this issue ? running into the same problem with the new BSEC_2.2.0.0 release

[mcalisterkm]

See the steps I set out for the last BSEC update: Issue - Can't Compile because of Library Update?
The crux of it is to rename the folder BSEC_2.2.0.0_Generic_Release_30052022 to the old name BSEC_2.0.6.1_Generic_Release_04302021.

Unfortunately this folder name is hard coded into setup.py.
Rename the BSEC folder and follow the notes.

It's a work around, and others have suggested the BSEC version is a parameter or parsed but that is up to PI3G.

Keith

[Blandi88]

See the steps I set out for the last BSEC update: Issue - Can't Compile because of Library Update? The crux of it is to rename the folder BSEC_2.2.0.0_Generic_Release_30052022 to the old name BSEC_2.0.6.1_Generic_Release_04302021.

Unfortunately this folder name is hard coded into setup.py. Rename the BSEC folder and follow the notes.

It's a work around, and others have suggested the BSEC version is a parameter or parsed but that is up to PI3G.

Keith

This method does not work for bsec2.2.x.x

[Blandi88]

any news on this issue ? running into the same problem with the new BSEC_2.2.0.0 release

After renaming all config files in the code, I got it to compile by additionally getting rid of all references to the following lines;

BSEC_SAMPLE_RATE_HIGH_PERFORMANCE
BSEC_OUTPUT_COMPENSATED_GAS

^these are not used in the newest implementation of bsec 2.2.x.x

[mcalisterkm]

The first error is easily fixed by swapping BSEC_SAMPLE_RATE_HIGH_PERFORMANCE to BSEC_SAMPLE_RATE_SCAN which is the same value. The second error is more complex as it is an enumerated value in the BOSCH header bsec_datatypes.h, but in the PI3G code BSEC_OUTPUT_COMPENSATED_GAS is a virtual sensor and part of a data structure holding output values for the BSEC virtual sensors. I thought the easiest approach was to add the definition back into the BOSCH header (bsec_datatypes.h) like this
BSEC_OUTPUT_SENSOR_HEAT_COMPENSATED_HUMIDITY = 15,
BSEC_OUTPUT_COMPENSATED_GAS = 18,
BSEC_OUTPUT_GAS_PERCENTAGE = 21,

It compiles and installs but is throwing errors "SystemError: ../Objects/longobject.c:415: bad argument to internal function".

So I think BSEC_OUTPUT_COMPENSATED_GAS has to be removed in the PI3G code, from the virtual sensor data structure and its processing, which is more than a quick hack. It's annoying that BOSCH have made such breaking changes with no information/release note. It's even more annoying that BOSCH have removed the previous versions of the library from their website.

[Blandi88]

The first error is easily fixed by swapping BSEC_SAMPLE_RATE_HIGH_PERFORMANCE to BSEC_SAMPLE_RATE_SCAN which is the same value. The second error is more complex as it is an enumerated value in the BOSCH header bsec_datatypes.h, but in the PI3G code BSEC_OUTPUT_COMPENSATED_GAS is a virtual sensor and part of a data structure holding output values for the BSEC virtual sensors. I thought the easiest approach was to add the definition back into the BOSCH header (bsec_datatypes.h) like this BSEC_OUTPUT_SENSOR_HEAT_COMPENSATED_HUMIDITY = 15, BSEC_OUTPUT_COMPENSATED_GAS = 18, BSEC_OUTPUT_GAS_PERCENTAGE = 21,

It compiles and installs but is throwing errors "SystemError: ../Objects/longobject.c:415: bad argument to internal function".

So I think BSEC_OUTPUT_COMPENSATED_GAS has to be removed in the PI3G code, from the virtual sensor data structure and its processing, which is more than a quick hack. It's annoying that BOSCH have made such breaking changes with no information/release note. It's even more annoying that BOSCH have removed the previous versions of the library from their website.

Go read the integration manual in the bsec2.2.x.x file you downloaded. Looks like you found the solution for BSEC_SAMPLE_RATE_HIGH_PERFORMANCE

however,

BSEC_OUTPUT_COMPENSATED_GAS

^this is no longer used at all.

[mcalisterkm]

I have read the integration manual. Table 1.2.4 lists the virtual sensors, and BOSCH have removed the BSEC_OUTPUT_COMPENSATED_GAS sensor. According to the guide. In the 2.0.6.1 code it was marked as internal and I think it is very much still there, its just become undocumented. So put it back into the enumerated list and bingo it compiles and installs. I have been running my burnin.py program over night and it is still running this morning, using BSEC 2.2.0 and the 1.3v bme688x code. I ran the air quality.py example and it was OK, but my sensor apps had a problem as I reported. So my next step is to let the burnin finish and see if the saved config will load, and test some more.

Just for reference from the 2.0.6.1 guide BSEC_OUTPUT_COMPENSATED_GAS is the Gas Resistance after undergoing temp and humidity compensation. I guess they are not happy with the algorithm.

I have also emailed Nathan the PI3G maintainer.

[Blandi88]

I have read the integration manual. Table 1.2.4 lists the virtual sensors, and BOSCH have removed the BSEC_OUTPUT_COMPENSATED_GAS sensor. According to the guide. In the 2.0.6.1 code it was marked as internal and I think it is very much still there, its just become undocumented. So put it back into the enumerated list and bingo it compiles and installs. I have been running my burnin.py program over night and it is still running this morning, using BSEC 2.2.0 and the 1.3v bme688x code. I ran the air quality.py example and it was OK, but my sensor apps had a problem as I reported. So my next step is to let the burnin finish and see if the saved config will load, and test some more.

Just for reference from the 2.0.6.1 guide BSEC_OUTPUT_COMPENSATED_GAS is the Gas Resistance after undergoing temp and humidity compensation. I guess they are not happy with the algorithm.

I have also emailed Nathan the PI3G maintainer.

I am able to compile if I change all the fields for BSEC_SAMPLE_RATE_HIGH_PERFORMANCE to BSEC_SAMPLE_RATE_SCAN

And delete all references to BSEC_OUTPUT_COMPENSATED_GAS

I am not sure if this breaks anything, but it works. I can run bmerawdata.py

[mcalisterkm]

All the samples run without error and I can write and read state (but not state written by 2.0.6.1).
So I have had to re-run my burn-in and create a new state file.

I have made a clone of this repo fixed to work with BSEC 2.2.0 see https://github.com/mcalisterkm/bme68x-python-library-bsec2.2.0. Note there is an additional step in the installation. This is just a temporary fix until PI3G do an update.

Regards
Keith

[Blandi88]

All the samples run without error and I can write and read state (but not state written by 2.0.6.1). So I have had to re-run my burn-in and create a new state file.

I have made a clone of this repo fixed to work with BSEC 2.2.0 see https://github.com/mcalisterkm/bme68x-python-library-bsec2.2.0. Note there is an additional step in the installation. This is just a temporary fix until PI3G do an update.

Regards Keith

Ran this all last night but woke up to bemrawdata.py giving me a segmentation fault

[mcalisterkm]

Yes there are a quite a few problems to work on: IAQ and CO2 with 2.2.0 are giving crazy values compared to 2.0.6.1.
bmerawdata.py runs but I guess it is failing after some time, and segmentation fault is not great.
I am running bmerawdata now to see if I can re-create.

[Blandi88]

Yes there are a quite a few problems to work on: IAQ and CO2 with 2.2.0 are giving crazy values compared to 2.0.6.1.
bmerawdata.py runs but I guess it is failing after some time, and segmentation fault is not great.
I am running bmerawdata now to see if I can re-create.

The segmentation fault error seems it might stemming from a usb keyboard dongle I have plugged in? Is this even possible?

[mcalisterkm]

The crazy values were coming from the API which has been updated to 4.4.7 - https://github.com/BoschSensortec/Bosch-BME68x-Library. The PI3G library has a copy of v4.4.3 embedded as BME68x-Sensor-API. Updating that to v4.4.7 has improved the IAQ and CO2 values. I have updated my clone here: https://github.com/mcalisterkm/bme68x-python-library-bsec2.2.0.

Try collecting data for 30 min or so with bmerawdata.py.

[ChuckKollar]

I just wasted about 4 hours on this including making suggested changes.

Here is what I have so far. I figured out that the old version of the BSEC_Generic_Release had changed so I did a find . -type f -exec grep OLDLIB {} ; -ls in bme68x-python-library and replaced all old references with the new one. Would have been simpler to just rename it in retrospect as suggested.

Then I did as suggested I change all the fields for BSEC_SAMPLE_RATE_HIGH_PERFORMANCE to BSEC_SAMPLE_RATE_SCAN
And delete all references to BSEC_OUTPUT_COMPENSATED_GAS

Now I'm getting loads of warnings, but in the end his error....
/usr/bin/ld: skipping incompatible BSEC_2.2.0.0_Generic_Release_30052022/algo/normal_version/bin/RaspberryPi/PiThree_ArmV6/libalgobsec.a when searching for -lalgobsec
/usr/bin/ld: cannot find -lalgobsec
collect2: error: ld returned 1 exit status

Any suggestions on how I should proceed would be welcome, and thank you so much in advance.

Charles

$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"