You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ShadowCoder1
I checked the code and here are some of my comments
you might want to add a argparse parser for your open_motor.py (you data filter program) This is very common in nowadays Python-based projects.
You definitely still need an overall design doc in your repo. It's not clear additional_information.py and upload_csv.py do at the moment.
Agree with JT that you probably need few demos papers also in the repo.
Jupyter-notebook is usually helpful for demo-ing.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
@ShadowCoder1
I checked the code and here are some of my comments
you might want to add a argparse parser for your open_motor.py (you data filter program) This is very common in nowadays Python-based projects.
You definitely still need an overall design doc in your repo. It's not clear additional_information.py and upload_csv.py do at the moment.
Agree with JT that you probably need few demos papers also in the repo.
Jupyter-notebook is usually helpful for demo-ing.
Beta Was this translation helpful? Give feedback.
All reactions