From 2052bd38d461c260fd53a5d11003263438e43f74 Mon Sep 17 00:00:00 2001 From: James Titcumb Date: Tue, 24 Feb 2026 09:41:15 +0000 Subject: [PATCH 1/2] Added CONTRIBUTING.md and PR template --- .github/pull_request_template.md | 13 +++++++++++++ CONTRIBUTING.md | 30 ++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 .github/pull_request_template.md create mode 100644 CONTRIBUTING.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..ca50148d --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,13 @@ + + + + + + + +## PR submitter checklist + +- [ ] I have read [CONTRIBUTING.md](../CONTRIBUTING.md) +- [ ] I discussed this with the maintainers in # (complete as appropriate) +- [ ] I have added appropriate tests +- [ ] I confirm that I have the right to submit this under the project's open source licence diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 00000000..4a5c0e57 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,30 @@ +# Contributing to PIE + +Thank you for taking an interest in contributing to PIE. + +> [!IMPORTANT] +> The TL;DR version of this is please either [open an issue](https://github.com/php/pie/issues) if you think you have +> found a bug, or [create a discussion](https://github.com/php/pie/discussions) if you have an idea for a new feature, +> **BEFORE** starting work on any code changes. Submitting a pull request without checking first may be duplicating +> work that is already in progress! + +## Reporting bugs + +If you think you have a bug, please [open an issue](https://github.com/php/pie/issues), and include: + + - What platform and PIE version you're using + - The steps to reproduce the issue - please use the `-v` verbose flag (or higher) + - Complete error messages and/or logs, including stack traces (hint: use `-v` for verbose), but please redact sensitive information + +## Submitting PRs + +Please **do not** just submit PRs for features or ideas without discussing them first. **Start by +[creating a discussion](https://github.com/php/pie/discussions) first** if there is not already an open discussion or +issue. If there is already an open discussion or issue, please comment and wait for feedback before starting any work. +This is because the work may already be in progress or being investigated already. The PIE project is actively being +developed, and many features are already in discussion or being developed, so if you do not discuss with us first, you +may be duplicating work already in progress. + +> [!TIP] +> We try to stay on top of issues already being worked on with the `maintainer investigating` purple label. If you see +> this on an issue, it is very likely we are already looking into this. From db110ff70cc3f621c2e1c375cb9627d88e6c1ee6 Mon Sep 17 00:00:00 2001 From: James Titcumb Date: Tue, 24 Feb 2026 10:27:45 +0000 Subject: [PATCH 2/2] Fixes #514 disable Windows build --- .github/workflows/build-assets.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-assets.yml b/.github/workflows/build-assets.yml index 4a0f340f..234ad304 100644 --- a/.github/workflows/build-assets.yml +++ b/.github/workflows/build-assets.yml @@ -76,7 +76,7 @@ jobs: - ubuntu-24.04-arm - macos-15-intel - macos-26 - - windows-2025 + # - windows-2025 # disabled - https://github.com/crazywhalecc/static-php-cli/issues/1039 permissions: # id-token:write is required for build provenance attestation. id-token: write