From f813fdd33538343b9f3e008619f95d289fc37701 Mon Sep 17 00:00:00 2001 From: Bellangelo Date: Fri, 10 Jan 2025 10:03:13 +0200 Subject: [PATCH 1/3] setup-php action sets the composer auth through the GITHUB_TOKEN env --- .github/workflows/continuous-integration.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index c3e6716f..9f251c75 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -29,7 +29,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - uses: actions/checkout@v4 - - run: composer config --global github-oauth.github.com ${{ secrets.GITHUB_TOKEN }} # temporarily remove Psalm until ready for PHP 8.4 - name: remove psalm if: matrix.php-versions == '8.4' From c514bb0554ee1fdafc232ce49789dacb19496e26 Mon Sep 17 00:00:00 2001 From: Bellangelo Date: Fri, 10 Jan 2025 10:04:10 +0200 Subject: [PATCH 2/3] Make GITHUB_TOKEN available to all commands --- .github/workflows/continuous-integration.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 9f251c75..43d7d88f 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -10,6 +10,8 @@ permissions: jobs: unit-tests: runs-on: ${{ matrix.operating-system }} + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} strategy: matrix: operating-system: @@ -26,8 +28,6 @@ jobs: with: php-version: ${{ matrix.php-versions }} extensions: intl, sodium, zip - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - uses: actions/checkout@v4 # temporarily remove Psalm until ready for PHP 8.4 - name: remove psalm From 10a7299276b306d6259b1ed2be0000db865cea52 Mon Sep 17 00:00:00 2001 From: James Titcumb Date: Tue, 14 Jan 2025 09:39:52 +0000 Subject: [PATCH 3/3] Only pass GITHUB_TOKEN to steps that actually need it --- .github/workflows/continuous-integration.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 43d7d88f..a1ad3c68 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -10,8 +10,6 @@ permissions: jobs: unit-tests: runs-on: ${{ matrix.operating-system }} - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} strategy: matrix: operating-system: @@ -28,6 +26,8 @@ jobs: with: php-version: ${{ matrix.php-versions }} extensions: intl, sodium, zip + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - uses: actions/checkout@v4 # temporarily remove Psalm until ready for PHP 8.4 - name: remove psalm @@ -37,9 +37,13 @@ jobs: - name: Run PHPUnit on Windows if: matrix.operating-system == 'windows-latest' run: vendor/bin/phpunit + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Run PHPUnit on non-Windows if: matrix.operating-system != 'windows-latest' run: sudo vendor/bin/phpunit + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} behaviour-tests: runs-on: ${{ matrix.operating-system }}