From d8c06b3ef7cbd3651cd3d326c0382d74d2e5c56d Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:30:27 +0000 Subject: [PATCH 1/7] Add more commands to check build status --- .github/workflows/build.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7f00301ad..d58dbc1c0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,4 +21,7 @@ jobs: run: | git clone --depth=1 https://github.com/php/doc-base.git doc-base git clone --depth=1 https://github.com/php/doc-en.git en + php doc-base/scripts/broken.php it + php doc-base/scripts/qaxml.e.php + php doc-base/scripts/qaxml.a.php php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it From 12f61053636cb42ad2b66c5ef6c9094b06527b38 Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:39:12 +0000 Subject: [PATCH 2/7] Split into steps --- .github/workflows/build.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d58dbc1c0..95cf56d9a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,11 +17,15 @@ jobs: with: path: 'it' - - name: Build docs + - name: Clone doc-en and doc-base run: | git clone --depth=1 https://github.com/php/doc-base.git doc-base git clone --depth=1 https://github.com/php/doc-en.git en - php doc-base/scripts/broken.php it - php doc-base/scripts/qaxml.e.php - php doc-base/scripts/qaxml.a.php - php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it + - name: Validate files + run: php doc-base/scripts/broken.php it + - name: qaxml-attributes.php + run: php doc-base/scripts/translation/qaxml-attributes.php --urgent + - name: qaxml-entities.php + run: doc-base/scripts/translation/qaxml-entities.php --urgent + - name: configure.php + run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it From 6ae60eff7e1d1c2ca8879bd8210e9d3038693cde Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:43:07 +0000 Subject: [PATCH 3/7] Fix command --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 95cf56d9a..dec81e0ca 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,6 +26,6 @@ jobs: - name: qaxml-attributes.php run: php doc-base/scripts/translation/qaxml-attributes.php --urgent - name: qaxml-entities.php - run: doc-base/scripts/translation/qaxml-entities.php --urgent + run: php doc-base/scripts/translation/qaxml-entities.php --urgent - name: configure.php run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it From b4527f27bd3d248d1f31d2cbb72b3d5674a956c9 Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:47:06 +0000 Subject: [PATCH 4/7] Add folder argument --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dec81e0ca..ae4d7ee6d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -24,8 +24,8 @@ jobs: - name: Validate files run: php doc-base/scripts/broken.php it - name: qaxml-attributes.php - run: php doc-base/scripts/translation/qaxml-attributes.php --urgent + run: php doc-base/scripts/translation/qaxml-attributes.php it --urgent - name: qaxml-entities.php - run: php doc-base/scripts/translation/qaxml-entities.php --urgent + run: php doc-base/scripts/translation/qaxml-entities.php it --urgent - name: configure.php run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it From 902530eb381e2edf05aaecdc9cc115d147d3859d Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:51:00 +0000 Subject: [PATCH 5/7] Re-arrange steps --- .github/workflows/build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ae4d7ee6d..0c5ffbd4d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,11 +21,11 @@ jobs: run: | git clone --depth=1 https://github.com/php/doc-base.git doc-base git clone --depth=1 https://github.com/php/doc-en.git en - - name: Validate files - run: php doc-base/scripts/broken.php it - - name: qaxml-attributes.php - run: php doc-base/scripts/translation/qaxml-attributes.php it --urgent - - name: qaxml-entities.php - run: php doc-base/scripts/translation/qaxml-entities.php it --urgent - name: configure.php run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it + - name: Validate files + run: php doc-base/scripts/broken.php it + - name: qaxml-attributes.php + run: php doc-base/scripts/translation/qaxml-attributes.php --urgent + - name: qaxml-entities.php + run: php doc-base/scripts/translation/qaxml-entities.php --urgent From 6a0239311c7109206fe92b7b6901ce82269a0e0a Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Wed, 19 Feb 2025 14:53:26 +0000 Subject: [PATCH 6/7] Remove --depth for doc-en --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0c5ffbd4d..64240bad3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,7 @@ jobs: - name: Clone doc-en and doc-base run: | git clone --depth=1 https://github.com/php/doc-base.git doc-base - git clone --depth=1 https://github.com/php/doc-en.git en + git clone https://github.com/php/doc-en.git en - name: configure.php run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it - name: Validate files From 5332bca5609b96437f279d86f4427d57df1fce49 Mon Sep 17 00:00:00 2001 From: Davide Pastore Date: Mon, 24 Mar 2025 14:37:13 +0000 Subject: [PATCH 7/7] Use one single step to execute all the checks --- .github/workflows/build.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 64240bad3..3b8dea633 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -23,9 +23,8 @@ jobs: git clone https://github.com/php/doc-en.git en - name: configure.php run: php doc-base/configure.php --enable-xml-details --disable-libxml-check --redirect-stderr-to-stdout --with-lang=it - - name: Validate files - run: php doc-base/scripts/broken.php it - - name: qaxml-attributes.php - run: php doc-base/scripts/translation/qaxml-attributes.php --urgent - - name: qaxml-entities.php - run: php doc-base/scripts/translation/qaxml-entities.php --urgent + - name: Checks + run: | + php doc-base/scripts/broken.php it + php doc-base/scripts/translation/qaxml-attributes.php --urgent + php doc-base/scripts/translation/qaxml-entities.php --urgent \ No newline at end of file