fix(tests): Settings e2e test suite tests the Zustand store directly, not the settings UI flow

[github-actions]

Summary

Every assertion in settings-flow.test.tsx goes through usePreferencesStore.getState() directly. The test suite will pass even if the real settings page stops rendering the correct controls, miswires event handlers, or fails to hydrate from the store — because the real component is never involved.

Affected file

src/UILayer/web/src/__tests__/e2e/settings-flow.test.tsx — line 54

Required fix

Render the real settings page component and interact with it via user events (userEvent.click, userEvent.type). Assert on what the user sees (rendered output) rather than internal store state.

References

• PR Phase 16: Remaining widgets, role-based UI, frontend tests #361 review: Phase 16: Remaining widgets, role-based UI, frontend tests #361 (comment)
• Severity: 🟠 Major

[blocksorg]

Mention Blocks like a regular teammate with your question or request:

@blocks can you add technical details to this issue?
@blocks make the following changes ...
@blocks create an issue from what was mentioned in the following comment ...
@blocks explain the following code ...
@blocks are there any security or performance concerns?

Run @blocks /help for more information.

Workspace settings | Disable this message