Skip to content

[HIGH] Proxy authentication without shared secret #338

@iamgp

Description

@iamgp

Summary

ProxyAuthenticationProvider validates based solely on source IP CIDR ranges. No shared secret or request signing validates header authenticity. Attackers within trusted network can forge identity headers.

Location

src/phlo/capabilities/authentication.py lines 221-335

Vulnerable Code

def _is_trusted_proxy(self, client_ip: str) -> bool:
    for cidr in self._trusted_proxy_cidrs:
        if ipaddress.ip_address(client_ip) in ipaddress.ip_network(cidr):
            return True

Recommended Fix

  1. Require mTLS between proxy and service, or
  2. Validate signed JWT/assertions from the proxy, or
  3. Reject requests without proxy authentication signatures

Severity: P1 - High
Category: Security
Audit Reference: AUDIT.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions