-
Notifications
You must be signed in to change notification settings - Fork 0
[HIGH] Proxy authentication without shared secret #338
Copy link
Copy link
Closed
Description
Summary
ProxyAuthenticationProvider validates based solely on source IP CIDR ranges. No shared secret or request signing validates header authenticity. Attackers within trusted network can forge identity headers.
Location
src/phlo/capabilities/authentication.py lines 221-335
Vulnerable Code
def _is_trusted_proxy(self, client_ip: str) -> bool:
for cidr in self._trusted_proxy_cidrs:
if ipaddress.ip_address(client_ip) in ipaddress.ip_network(cidr):
return TrueRecommended Fix
- Require mTLS between proxy and service, or
- Validate signed JWT/assertions from the proxy, or
- Reject requests without proxy authentication signatures
Severity: P1 - High
Category: Security
Audit Reference: AUDIT.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels