-
Notifications
You must be signed in to change notification settings - Fork 36
Description
When trying to install the https://github.com/pheryjs/phery/tree/3.0.0-alpha1 branch using Composer like this:
{
"require": {
"phery/phery": "dev-3.0.0-alpha1"
}
}A composer install results in:
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking phery/phery (dev-3.0.0-alpha1 8276dcc)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing phery/phery (dev-3.0.0-alpha1 8276dcc): Extracting archive
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
As you can see a commit 8276dcc is installed. Apparent the tag https://github.com/pheryjs/phery/releases/tag/3.0.0-alpha.1 is installed. Note that the name of this tag is 3.0.0-alpha.1, I think the alpha.1 suffix is not supported.
So when trying to install branch 3.0.0-alpha1 in fact, tag 3.0.0-alpha.1 is installed.
To circumvent this, one can specify a specific commit to install, for example 56aacf1 :
{
"require": {
"phery/phery": "dev-3.0.0-alpha1#56aacf17016f3b100364d968a0417171d575f8d4"
}
}But it might be better to prevent this kind of workarounds. I am willing to spend some time to get this library up-to-date for PHP: add PHPStan for static analysis, increase strictness / typing, etc. However, we are still not using JQuery 3.0.
#53 (comment) suggests that in that case the https://github.com/pheryjs/phery/tree/3.0.0-alpha1 should be used. Maybe replace the "alpha1" suffix with "beta"? Or "RC1"?