Review the listing and correct variable labels as needed

[ddsjoberg]

For variables in the listing, the description should match the proper label from the implementation guide.

For example, these variables do not need a "derive" prefix

[ddsjoberg]

@bms63 @manciniedoardo @bundfussr is there a listing somewhere out there with all the variable labels?

[manciniedoardo]

@ddsjoberg we use the following in {pharmaverseadam}: https://github.com/pharmaverse/pharmaverseadam/blob/main/inst/extdata/adams-specs.json

[ddsjoberg]

Thanks @manciniedoardo !! If anyone on the admiral team is looking for something fun, please feel free to assign them to this one 👯

[bms63]

What does someone need to do here?

[ddsjoberg]

@bms63 there is a CSV file with all the variables, variable labels, links to examples, etc. They would just need to grab the correct variable labels, and update the file with them.

[bms63]

@pharmaverse/admiral or @pharmaverse/admiral_comm any takers? A big help for those looking to learn admiral

[jimrothstein]

@bms63
This seems doable. I will take a look, but always welcome a 2nd person to work together.

[manciniedoardo]

Go for it @jimrothstein !

[ddsjoberg]

@jimrothstein this is the file that needs to be updated : https://github.com/pharmaverse/admiraldiscovery/blob/main/inst/admiral-lookup-book.csv

You'll update the variable_label column.

1. I would import the csv file
2. Import the https://github.com/pharmaverse/pharmaverseadam/blob/main/inst/extdata/adams-specs.json file and create a data frame of the results. The data frame would have columns for adam dataset name, variable name, and variable column.
3. You can use dplyr::rows_update(unmatched="ignore") to update the imported CSV file.
4. Then resave the CSV file

Thanks!

[jimrothstein]

@ddsjoberg
I don't have write access. You want me to fork and push?

[ddsjoberg]

HI @jimrothstein yeah, let's fork and merge for this one. thanks

[jimrothstein]

@ddsjoberg
Just want to be sure, I'm on the right path:

1.
In your example, at top

`EODST` NOW has label `Derive end of study date`

2.
Here is ADaMIG v1.3 says: (Section 2.3)

 End of Study Date

3.
And here is I found from the adams-spec.json in pharmaverseadam (converted to tibble...)

End of Study Date

Since 2 & 3 match, I assume End of Study Date is correct and will proceed with code you have already outlined.
No change to FUNCTION column admiral::derive_vars_merged ?

If OK, I'll proceed.