From 69cafa21fe477329246968eb6c84f85d2af48491 Mon Sep 17 00:00:00 2001 From: HiranoMasaaki Date: Sat, 3 Jan 2026 07:34:43 +0000 Subject: [PATCH 1/2] refactor(create-expert): document integration-manager design rationale MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add explicit Design Rationale section to integration-manager explaining why multiple responsibilities (orchestration, trade-off analysis, scoring) are appropriate for this expert. Key points: - All responsibilities are "integration" concerns requiring combined results - Splitting would add complexity without benefit - Trade-off analysis needs both functional and usability context - Scoring requires holistic view across all test results Also refactored instruction to use declarative style: - Replaced numbered workflow with "Testing Strategy" and "Responsibilities" - Added "Delegates" section matching other expert patterns Closes #383 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- apps/create-expert/src/lib/create-expert-toml.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/apps/create-expert/src/lib/create-expert-toml.ts b/apps/create-expert/src/lib/create-expert-toml.ts index c3a09533..7b17634a 100644 --- a/apps/create-expert/src/lib/create-expert-toml.ts +++ b/apps/create-expert/src/lib/create-expert-toml.ts @@ -267,15 +267,23 @@ Return functional test report with pass/fail counts per category. const INTEGRATION_MANAGER_INSTRUCTION = `You orchestrate coordinated functional and usability testing. +## Design Rationale + +This expert has multiple responsibilities (orchestration, trade-off analysis, scoring) +because they are all "integration" concerns - they require seeing both functional and +usability results together. Splitting these would require passing combined context +between more experts, adding complexity without benefit. + ## Your Role -You coordinate parallel testing through functional-manager and usability-manager, then provide holistic quality assessment. +Coordinate parallel testing through functional-manager and usability-manager, +then provide holistic quality assessment. ## Delegates - \`functional-manager\`: Tests happy-path, unhappy-path, and adversarial scenarios - \`usability-manager\`: Tests demo, setup, doctor, and error guidance ## Testing Strategy -Delegate to both managers simultaneously for efficiency. They operate independently and return their own reports. +Delegate to both managers simultaneously for efficiency. They operate independently. ## Quality Assessment Responsibilities From aab1396a4f6af03ed28d390f672cf8ca25c833c8 Mon Sep 17 00:00:00 2001 From: HiranoMasaaki Date: Sat, 3 Jan 2026 07:40:16 +0000 Subject: [PATCH 2/2] chore: add changeset for #383 --- .changeset/refactor-383-integration-manager-rationale.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/refactor-383-integration-manager-rationale.md diff --git a/.changeset/refactor-383-integration-manager-rationale.md b/.changeset/refactor-383-integration-manager-rationale.md new file mode 100644 index 00000000..cae27bcc --- /dev/null +++ b/.changeset/refactor-383-integration-manager-rationale.md @@ -0,0 +1,6 @@ +--- +"create-expert": patch +--- + +Document integration-manager design rationale +