Skip to content

Fix: Demo Expert template includes readTextFile which may not be needed #361

@FL4TLiN3

Description

@FL4TLiN3

Description

The ecosystem-builder's Demo Expert template in create-expert-toml.ts omits readTextFile from pick, but the template description says "Use sample/mock data instead of real API calls", which implies the demo should be self-contained.

Current Behavior

Demo Expert Template (lines 161-166):

[experts."<name>-demo".skills."@perstack/base"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["think", "attemptCompletion"]

This only includes think and attemptCompletion, which is good for minimal privilege.

Issue

The instruction (lines 139-159) says:

## Demo Mode
- Use sample/mock data instead of real API calls
...
## Sample Data
[Include relevant sample data for demonstration]

But "Include relevant sample data" is ambiguous:

  1. Does the expert embed sample data in its instruction?
  2. Or should the expert read sample data files from workspace?

If sample data is embedded in instruction, the current pick is correct.
If sample data is in files, readTextFile should be added to pick.

Recommendation

Clarify in the template:

  1. Sample data should be embedded in the instruction (preferred for true zero-config)
  2. Or explicitly add readTextFile if files are used

Example clarification:

## Sample Data (embedded in instruction)
Below is sample data for demonstration. Do NOT read from files.

[Embed actual sample data here]

Affected Areas

  • apps/create-expert/src/lib/create-expert-toml.ts:135-166 (Demo Expert template)

Acceptance Criteria

  • Clarify whether sample data is embedded or read from files
  • Ensure pick matches the intended behavior

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcreate-expertcreate-expert CLI package

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions