-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
bugSomething isn't workingSomething isn't workingcreate-expertcreate-expert CLI packagecreate-expert CLI package
Description
Description
The ecosystem-builder's Demo Expert template in create-expert-toml.ts omits readTextFile from pick, but the template description says "Use sample/mock data instead of real API calls", which implies the demo should be self-contained.
Current Behavior
Demo Expert Template (lines 161-166):
[experts."<name>-demo".skills."@perstack/base"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["think", "attemptCompletion"]This only includes think and attemptCompletion, which is good for minimal privilege.
Issue
The instruction (lines 139-159) says:
## Demo Mode
- Use sample/mock data instead of real API calls
...
## Sample Data
[Include relevant sample data for demonstration]But "Include relevant sample data" is ambiguous:
- Does the expert embed sample data in its instruction?
- Or should the expert read sample data files from workspace?
If sample data is embedded in instruction, the current pick is correct.
If sample data is in files, readTextFile should be added to pick.
Recommendation
Clarify in the template:
- Sample data should be embedded in the instruction (preferred for true zero-config)
- Or explicitly add
readTextFileif files are used
Example clarification:
## Sample Data (embedded in instruction)
Below is sample data for demonstration. Do NOT read from files.
[Embed actual sample data here]Affected Areas
apps/create-expert/src/lib/create-expert-toml.ts:135-166(Demo Expert template)
Acceptance Criteria
- Clarify whether sample data is embedded or read from files
- Ensure pick matches the intended behavior
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcreate-expertcreate-expert CLI packagecreate-expert CLI package