-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
create-expertcreate-expert CLI packagecreate-expert CLI packagerefactorCode improvement without behavior changeCode improvement without behavior change
Description
Description
The property-extractor lists Perstack Properties to verify, but this list is incomplete compared to the documentation and AGENTS.md template.
Current State
PROPERTY_EXTRACTOR_INSTRUCTION (lines 52-58) lists:
### Perstack Properties (built-in quality checks)
1. Single Responsibility: Expert does one thing well
2. Clear Instructions: No ambiguous or procedural instructions
3. Appropriate Skills: Only necessary skills are included
4. Error Handling: Graceful failure with helpful messages
5. Security: No path traversal, no instruction leakageCompare to AGENTS.md Template
agents-md-template.ts (lines 68-73) lists different properties:
**Perstack Properties** (always verified):
- PS-SEC-01: Minimal tool access (uses `pick`)
- PS-SEC-02: Minimal environment (`requiredEnv`)
- PS-INST-01: Declarative instruction style
- PS-INST-02: Contains domain knowledge
- PS-OUT-01: Uses `attemptCompletion`
- PS-OUT-02: Explicit output formatInconsistencies
| AGENTS.md Property | property-extractor | Notes |
|---|---|---|
PS-SEC-01: Minimal tool access (pick) |
"Appropriate Skills: Only necessary skills" | Similar but different wording |
| PS-SEC-02: Minimal environment | ❌ Missing | requiredEnv not mentioned |
| PS-INST-01: Declarative instruction | "Clear Instructions: No ambiguous or procedural" | Similar |
| PS-INST-02: Contains domain knowledge | ❌ Missing | Not mentioned |
| PS-OUT-01: Uses attemptCompletion | ❌ Missing | Not mentioned |
| PS-OUT-02: Explicit output format | ❌ Missing | Not mentioned |
Affected Areas
apps/create-expert/src/lib/create-expert-toml.ts:52-58(PROPERTY_EXTRACTOR_INSTRUCTION)apps/create-expert/src/lib/agents-md-template.ts:68-73(Perstack Properties section)
Acceptance Criteria
- Unify the Perstack Properties lists between files
- Use consistent property IDs (PS-SEC-01, etc.) or consistent descriptions
- Include all relevant properties in property-extractor
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
create-expertcreate-expert CLI packagecreate-expert CLI packagerefactorCode improvement without behavior changeCode improvement without behavior change