-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
bugSomething isn't workingSomething isn't workingcreate-expertcreate-expert CLI packagecreate-expert CLI package
Description
Description
The internal experts defined in apps/create-expert/src/lib/create-expert-toml.ts do not use the pick option to restrict tool access, violating the minimal privilege principle emphasized in the documentation.
Current Behavior
All internal experts define @perstack/base skill without pick:
[experts."create-expert".skills."@perstack/base"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"This pattern is repeated for all 8 internal experts:
create-expertproperty-extractorecosystem-builderintegration-managerfunctional-managerusability-managerexpert-testerreport-generator
Expected Behavior
Each expert should use pick to only expose the tools it actually needs, as documented in:
docs/making-experts/skills.md: "Usepick/omitto control which tools are available"docs/making-experts/best-practices.md: "Use Minimal Privilege"
For example:
property-extractorlikely only needs["think", "attemptCompletion"]ecosystem-builderneeds["readTextFile", "editTextFile", "think", "attemptCompletion"]expert-testerneeds["exec", "think", "attemptCompletion"]
Affected Areas
apps/create-expert/src/lib/create-expert-toml.ts:618-725(all skill definitions)
Acceptance Criteria
- Each internal expert uses
pickwith only the tools it requires - Tool selections are documented in comments
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcreate-expertcreate-expert CLI packagecreate-expert CLI package