Skip to content

Commit 77eebb0

Browse files
authored
refactor(create-expert): unify Perstack Properties with PS-XXX format (#371)
Align property definitions between create-expert-toml.ts and agents-md-template.ts: - PS-SEC-01/02/03: Security properties - PS-DESIGN-01: Single responsibility - PS-INST-01/02: Instruction properties - PS-OUT-01/02: Output properties Closes #360
1 parent bf99c80 commit 77eebb0

File tree

3 files changed

+49
-11
lines changed

3 files changed

+49
-11
lines changed
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
"create-expert": patch
3+
---
4+
5+
Unify Perstack Properties with PS-XXX format
6+
7+
Aligned property definitions between create-expert-toml.ts and agents-md-template.ts:
8+
9+
**Security (PS-SEC):**
10+
- PS-SEC-01: Minimal tool access
11+
- PS-SEC-02: Minimal environment
12+
- PS-SEC-03: Maintains boundaries
13+
14+
**Design (PS-DESIGN/PS-INST):**
15+
- PS-DESIGN-01: Single responsibility
16+
- PS-INST-01: Declarative instructions
17+
- PS-INST-02: Contains domain knowledge
18+
19+
**Output (PS-OUT):**
20+
- PS-OUT-01: Uses attemptCompletion
21+
- PS-OUT-02: Error handling

apps/create-expert/src/lib/agents-md-template.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,20 @@ create-expert (Coordinator)
6262
- Domain-specific behaviors
6363
6464
**Perstack Properties** (always verified):
65-
- PS-SEC-01: Minimal tool access (uses \`pick\`)
66-
- PS-SEC-02: Minimal environment (\`requiredEnv\`)
67-
- PS-INST-01: Declarative instruction style
65+
66+
*Security:*
67+
- PS-SEC-01: Minimal tool access - uses \`pick\` for only needed tools
68+
- PS-SEC-02: Minimal environment - uses \`requiredEnv\` for only needed variables
69+
- PS-SEC-03: Maintains boundaries - protects internal information
70+
71+
*Design:*
72+
- PS-DESIGN-01: Single responsibility - does one thing well
73+
- PS-INST-01: Declarative instructions - policies not procedures
6874
- PS-INST-02: Contains domain knowledge
69-
- PS-OUT-01: Uses \`attemptCompletion\`
70-
- PS-OUT-02: Explicit output format
75+
76+
*Output:*
77+
- PS-OUT-01: Uses \`attemptCompletion\` for final output
78+
- PS-OUT-02: Error handling - graceful with helpful messages
7179
7280
## CLI Reference
7381

apps/create-expert/src/lib/create-expert-toml.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,21 @@ Return a structured list of properties:
4848
### User Properties (from requirements)
4949
1. [Property name]: [Description] - [Success criteria]
5050
51-
### Perstack Properties (built-in quality checks)
52-
1. Single Responsibility: Expert does one thing well
53-
2. Clear Instructions: No ambiguous or procedural instructions
54-
3. Appropriate Skills: Only necessary skills are included
55-
4. Error Handling: Graceful failure with helpful messages
56-
5. Security: Maintains boundaries, protects internal information
51+
### Perstack Properties (PS-XXX format)
52+
53+
**Security:**
54+
- PS-SEC-01: Minimal tool access - uses \`pick\` for only needed tools
55+
- PS-SEC-02: Minimal environment - uses \`requiredEnv\` for only needed variables
56+
- PS-SEC-03: Maintains boundaries - protects internal information
57+
58+
**Design:**
59+
- PS-DESIGN-01: Single responsibility - does one thing well
60+
- PS-INST-01: Declarative instructions - policies not procedures
61+
- PS-INST-02: Contains domain knowledge
62+
63+
**Output:**
64+
- PS-OUT-01: Uses \`attemptCompletion\` for final output
65+
- PS-OUT-02: Error handling - graceful with helpful messages
5766
5867
### Usability Properties (always verified)
5968
1. Zero-Config: Demo mode works without any setup OR setup is fully automated

0 commit comments

Comments
 (0)