Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Error in function cutoff_first_bin #17

@aaolaveh

Description

@aaolaveh

Hi Matt, there is a little issue in cutoff_first_bin when check_skew =TRUE.

When the condition
sum(bin_idx[1L:(mid-1L)]) < sum(bin_idx[mid:num_bins])
is true (left-skewed) it returns
as.vector(cutree(hcl, k = 1L))
but it should return the height where the tree should be cut , i.e
max(hcl$height)

As it is, construct_pullback() returns error

Thanks and best regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions