remove usage of md5

ylebre · ylebre · commit fe2dd7cd091e · 2025-07-17T10:01:27.000+02:00
diff --git a/lib/Routes/SolidIdp.php b/lib/Routes/SolidIdp.php
@@ -117,8 +117,8 @@ public static function respondToRegister() {
 			}
 
 
-			$generatedClientId = md5(random_bytes(32));
-			$generatedClientSecret = md5(random_bytes(32));
+			$generatedClientId = bin2hex(random_bytes(16)); // 32 chars for the client Id
+			$generatedClientSecret = bin2hex(random_bytes(32)); // and 64 chars for the client secret
 
 			$clientData['client_id_issued_at'] = time();
 			$clientData['client_id'] = $generatedClientId;

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,8 @@ public static function respondToRegister() {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`
`120`		`- $generatedClientId = md5(random_bytes(32));`
`121`		`- $generatedClientSecret = md5(random_bytes(32));`
	`120`	`+ $generatedClientId = bin2hex(random_bytes(16)); // 32 chars for the client Id`
	`121`	`+ $generatedClientSecret = bin2hex(random_bytes(32)); // and 64 chars for the client secret`
`122`	`122`
`123`	`123`	`$clientData['client_id_issued_at'] = time();`
`124`	`124`	`$clientData['client_id'] = $generatedClientId;`