Skip to content

Commit fef6f96

Browse files
authored
Merge pull request #370 from ZLLentz/maint_unpin_pyqt
MAINT: unpin pyqt and fix test suite, REL: v1.18.4
2 parents 4a58e06 + a1e43f2 commit fef6f96

File tree

9 files changed

+39
-7
lines changed

9 files changed

+39
-7
lines changed

conda-recipe/meta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ requirements:
3939
- psdaq-control-minimal >=3.3.19
4040
- psdm_qs_cli >=0.3.1
4141
- pyfiglet >=0.8.0
42-
- pyqt <5.15.0
42+
- pyqt =5
4343
- pyyaml >=5.4.0
4444
- requests >=2.26.0
4545
- simplejson >=3.17.0

docs-requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
docs-versions-menu
12
nbsphinx
23
sphinx
34
sphinx_rtd_theme

docs/source/conf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"sphinx.ext.napoleon",
4242
"nbsphinx",
4343
"sphinx.ext.mathjax",
44+
"docs_versions_menu",
4445
]
4546

4647
# Add any paths that contain templates here, relative to this directory.

docs/source/releases.rst

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,30 @@
11
Release History
22
###############
33

4+
5+
v1.18.4 (2023-07-26)
6+
====================
7+
8+
Maintenance
9+
-----------
10+
- Unpin strict pyqt pin, we now just require pyqt5 of any flavor.
11+
- Fix a bug where non-conda installs and non-standard conda installs
12+
(like mambabuild intermediates) would be unable to use the
13+
`hutch-python --create` cookiecutter tool.
14+
- Add send and recv methods to the fake zmq socket because newer
15+
versions of the lcls2 daq code are expecting recv.
16+
- Fix pyproject.toml typo docs -> doc.
17+
- Update requirements.txt for accuracy now that
18+
psdaq-control-minimal is available on pypi.
19+
- Include docs-versions-menu for the sphinx docs builds.
20+
21+
22+
Contributors
23+
------------
24+
- klauer
25+
- zllentz
26+
27+
428
v1.18.3 (2023-04-11)
529
====================
630

hutch_python/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def main():
158158
except KeyError:
159159
# Take a stab at some non-conda defaults; ideally these would
160160
# be configurable with argparse.
161-
base = Path(sys.executable).parent
161+
base = str(Path(sys.executable).parent)
162162
env = hutch
163163
logger.info(('Creating hutch-python dir for hutch %s using'
164164
' base=%s env=%s'), hutch, base, env)

hutch_python/tests/conftest.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,13 @@ def send_json(self, *args, **kwargs):
250250
def recv_json(self, *args, **kwargs):
251251
return {}
252252

253+
def send(self, *args, **kwargs):
254+
pass
255+
256+
def recv(self, *args, **kwargs):
257+
# Trick the fake daq into stopping itself
258+
return b"shutdown"
259+
253260

254261
@pytest.fixture(scope='function')
255262
def dummy_zmq_lcls2(monkeypatch):

hutch_python/tests/test_tstpython.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ def test_tstpython_ipython():
5757
# then exit. There should be no NameError.
5858
ipy_text = check_output([tstpython], universal_newlines=True,
5959
input='unique_device\n')
60-
assert 'IPython' in ipy_text
60+
assert 'Environment Information' in ipy_text
6161
assert 'NameError' not in ipy_text

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ file = [ "requirements.txt",]
4444
[tool.setuptools.dynamic.optional-dependencies.test]
4545
file = "dev-requirements.txt"
4646

47-
[tool.setuptools.dynamic.optional-dependencies.docs]
47+
[tool.setuptools.dynamic.optional-dependencies.doc]
4848
file = "docs-requirements.txt"

requirements.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@ pcdscalc>=0.3.0
1212
pcdsdaq>=2.3.0
1313
pcdsdevices>=7.0.0
1414
pcdsutils>=0.5.0
15+
psdaq-control-minimal
1516
pyfiglet>=0.8.0
16-
pyqt5<5.15.0
17+
pyqt5
1718
pyyaml>=5.4.0
1819
requests>=2.26.0
1920
simplejson>=3.17.0
2021

2122
# Some are unavailable on pypi:
2223
# elog
23-
# psdaq-control-minimal
2424

2525
# Some are broken on pypi:
26-
# lightpath
2726
# psdm_qs_cli

0 commit comments

Comments
 (0)