From 5fda562ca9d17c2ade52558eac01b420ac59a326 Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Tue, 23 May 2023 23:32:52 +0000 Subject: [PATCH 1/3] :police_car: regenerate rubocop todo --- .rubocop_todo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2d540c9..88da7ea 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 180` -# on 2023-04-20 23:33:11 UTC using RuboCop version 1.50.2. +# on 2023-05-23 23:32:52 UTC using RuboCop version 1.51.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new From de7dea16e464d219527fe4e6151edb0b9d9a8b3b Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Tue, 23 May 2023 23:32:56 +0000 Subject: [PATCH 2/3] :police_car: RSpec/ImplicitSubject --- .rubocop_todo.yml | 7 ------- spec/lib/dispatch-rider/scheduled_job_spec.rb | 4 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 88da7ea..b64cecb 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -214,13 +214,6 @@ RSpec/FilePath: - 'spec/lib/dispatch-rider/subscriber_spec.rb' - 'spec/lib/dispatch-rider_spec.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit -RSpec/ImplicitSubject: - Exclude: - - 'spec/lib/dispatch-rider/scheduled_job_spec.rb' # Offense count: 3 # Configuration parameters: Max. diff --git a/spec/lib/dispatch-rider/scheduled_job_spec.rb b/spec/lib/dispatch-rider/scheduled_job_spec.rb index 57aabce..87c5893 100644 --- a/spec/lib/dispatch-rider/scheduled_job_spec.rb +++ b/spec/lib/dispatch-rider/scheduled_job_spec.rb @@ -54,8 +54,8 @@ subject { described_class.find(due_job.id).message } it { - is_expected.to eq "subject" => "war_update", - "body" => { "enigma_machine" => "broken" } + expect(subject).to eq "subject" => "war_update", + "body" => { "enigma_machine" => "broken" } } end From ab6e6eb28b1c92ad06148f33f8f5ed6792677bd0 Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Tue, 23 May 2023 23:33:02 +0000 Subject: [PATCH 3/3] :police_car: regenerate rubocop todo --- .rubocop_todo.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b64cecb..e39a1ed 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 180` -# on 2023-05-23 23:32:52 UTC using RuboCop version 1.51.0. +# on 2023-05-23 23:33:02 UTC using RuboCop version 1.51.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -214,7 +214,6 @@ RSpec/FilePath: - 'spec/lib/dispatch-rider/subscriber_spec.rb' - 'spec/lib/dispatch-rider_spec.rb' - # Offense count: 3 # Configuration parameters: Max. RSpec/IndexedLet: @@ -253,7 +252,7 @@ RSpec/MultipleExpectations: RSpec/MultipleMemoizedHelpers: Max: 12 -# Offense count: 173 +# Offense count: 174 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples. # SupportedStyles: always, named_only RSpec/NamedSubject: @@ -280,6 +279,7 @@ RSpec/NamedSubject: - 'spec/lib/dispatch-rider/registrars/publishing_destination_spec.rb' - 'spec/lib/dispatch-rider/registrars/queue_service_spec.rb' - 'spec/lib/dispatch-rider/registrars/sns_channel_spec.rb' + - 'spec/lib/dispatch-rider/scheduled_job_spec.rb' - 'spec/lib/dispatch-rider/subscriber_spec.rb' # Offense count: 27