__construct(): Argument #1 ($host) must be of type string, null given

[csimpi]

Hi, it seems this package doesn't work anymore, I've installed it and getting exceptions:

Pkerrigan\Xray\Submission\DaemonSegmentSubmitter::__construct(): Argument #1 ($host) must be of type string, null given, called in /var/app/current/vendor/napp/xray-laravel/src/Submission/DaemonSegmentSubmitter.php on line 44

[patrickkerrigan]

Hi,

It looks from your exception message like you're using napp/xray-laravel rather than this library directly, which is where the root cause of this exception seems to be. I'm not the maintainer of that, but I've had a go at debugging this as far as possible.

The exception is caused by null being used as the hostname for the X-Ray daemon rather than an actual hostname. Looking through the source code of vendor/napp/xray-laravel/src/Submission/DaemonSegmentSubmitter.php it appears that it gets the hostname and port of the X-Ray daemon from two environment variables, _AWS_XRAY_DAEMON_ADDRESS and _AWS_XRAY_DAEMON_PORT respectively before passing them to this library. The readme for napp/xray-laravel seems to confirm this.

I believe if you're deploying to AWS lambda then these will be set for you automatically, but if you're deploying to any other environment (e.g Docker, EC2 etc.) then you'll need to make sure these environment variables are set to point to a host that's running the X-Ray daemon.

As they're using the Laravel env function to get these environment variables then this may not work after Laravel 5 if you're caching your configs as per Laravel's documentation, with null being returned at runtime instead. If this is the case, and you are defining those environment variables and still getting this exception, then you'll probably want to raise it as a bug over at napp/xray-laravel where it can be fixed.

Hopefully this helps!