[Insight] Usage of a function in loops should be avoided - in src/Adapter/AmazonS3.php, line 180

[BernardoSilva]

in src/Adapter/AmazonS3.php, line 180

This loop uses a function. To avoid the overhead of executing the function n times, you should precalculate it before the loop.

        $this->ensureBucketExists();

        $files = $this->getFiles($sourceDir);

        $batch = array();
        for ($i = 0; $i < count($files); $i++) {
            $targetFile = str_replace($sourceDir, "", $files[$i]);
            $batch[] =  $this->service->getCommand('CopyObject', array(
                'Bucket'     => $targetBucket,
                'Key'        => "{$targetDir}{$targetFile}",
                'CopySource' => "{$sourceBucket}/{$files[$i]}",

---

Posted from SensioLabsInsight