From 3af9192d8fe3b038c10c8d220229c1e6b85184eb Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Wed, 27 Nov 2024 15:20:40 -0600 Subject: [PATCH 1/8] first pass at adding just tracking --- .../browser/content-meter-track.vue | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index 9191bc8f0..e36c47b1e 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -55,6 +55,7 @@ export default { overlayDisplayed, }, }; + this.trackP1Event('view'); dataLayer.push(payload); const { searchParams } = new URL(window.location.href); if (searchParams.has('idxDebugger')) { @@ -69,8 +70,22 @@ export default { this.EventBus.$on('identity-x-login-link-sent', ({ actionSource }) => { if (actionSource === 'content_meter_login') { this.classes.push('login-link-sent'); + this.trackP1Event('login-login-link-sent'); } }); }, + methods: { + trackP1Event(action) { + console.warn('action: ', action, window.p1events); + // triggercall here + window.p1events('track', { + category: 'Identity', + action, + label: 'content-meter', + // ctx, + // entity, + }); + }, + }, }; From c40aca20abc79248dcf8a0b45b9d7a46c574cd3a Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Wed, 27 Nov 2024 15:29:06 -0600 Subject: [PATCH 2/8] foix name and send props for now --- .../browser/content-meter-track.vue | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index e36c47b1e..32208e21b 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -70,7 +70,7 @@ export default { this.EventBus.$on('identity-x-login-link-sent', ({ actionSource }) => { if (actionSource === 'content_meter_login') { this.classes.push('login-link-sent'); - this.trackP1Event('login-login-link-sent'); + this.trackP1Event('login-link-sent'); } }); }, @@ -78,12 +78,16 @@ export default { trackP1Event(action) { console.warn('action: ', action, window.p1events); // triggercall here + const { views, remaining, overlayDisplayed } = this; window.p1events('track', { category: 'Identity', action, label: 'content-meter', - // ctx, - // entity, + props: { + views, + remaining, + overlayDisplayed, + }, }); }, }, From e5b99791ef0385c8654a2515819aa8654390296f Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 10:59:16 -0600 Subject: [PATCH 3/8] Add p1event tracking for view and submit --- .../browser/content-meter-track.vue | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index 32208e21b..748776c53 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -55,7 +55,7 @@ export default { overlayDisplayed, }, }; - this.trackP1Event('view'); + this.emitP1Event('View'); dataLayer.push(payload); const { searchParams } = new URL(window.location.href); if (searchParams.has('idxDebugger')) { @@ -70,25 +70,22 @@ export default { this.EventBus.$on('identity-x-login-link-sent', ({ actionSource }) => { if (actionSource === 'content_meter_login') { this.classes.push('login-link-sent'); - this.trackP1Event('login-link-sent'); + this.emitP1Event('Submit'); } }); }, methods: { - trackP1Event(action) { - console.warn('action: ', action, window.p1events); - // triggercall here + emitP1Event(action) { + if (!window.p1events) return; const { views, remaining, overlayDisplayed } = this; + const lab = !overlayDisplayed ? null : 'Gated'; window.p1events('track', { - category: 'Identity', + category: 'Content Meter', action, - label: 'content-meter', - props: { - views, - remaining, - overlayDisplayed, - }, + lab, + props: { n: views }, }); + this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); }, }, }; From bf51e8305fad779b1e768817a2ac453bdbad754a Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 11:06:09 -0600 Subject: [PATCH 4/8] send label correctly. --- .../marko-web-theme-monorail/browser/content-meter-track.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index 748776c53..a6c3e47dc 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -78,11 +78,12 @@ export default { emitP1Event(action) { if (!window.p1events) return; const { views, remaining, overlayDisplayed } = this; - const lab = !overlayDisplayed ? null : 'Gated'; + const label = !overlayDisplayed ? null : 'Gated'; + console.log('label: ', label) window.p1events('track', { category: 'Content Meter', action, - lab, + label, props: { n: views }, }); this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); From d690f0538febd4db150a917938e0d39b86669229 Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 11:09:44 -0600 Subject: [PATCH 5/8] correctly add label when set --- .../marko-web-theme-monorail/browser/content-meter-track.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index a6c3e47dc..b5174ab82 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -83,7 +83,7 @@ export default { window.p1events('track', { category: 'Content Meter', action, - label, + ...(label && { label }), props: { n: views }, }); this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); From 3aa29a99aeb4faffc057a1409f3ef85bd1c5d730 Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 11:49:18 -0600 Subject: [PATCH 6/8] Clean up console.log & passing/spreading of props --- .../browser/content-meter-track.vue | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index b5174ab82..620be23e8 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -55,7 +55,7 @@ export default { overlayDisplayed, }, }; - this.emitP1Event('View'); + this.emitP1Event({ action: 'View' }); dataLayer.push(payload); const { searchParams } = new URL(window.location.href); if (searchParams.has('idxDebugger')) { @@ -70,20 +70,18 @@ export default { this.EventBus.$on('identity-x-login-link-sent', ({ actionSource }) => { if (actionSource === 'content_meter_login') { this.classes.push('login-link-sent'); - this.emitP1Event('Submit'); + this.emitP1Event({ action: 'Submit' }); } }); }, methods: { - emitP1Event(action) { + emitP1Event({ action }) { if (!window.p1events) return; const { views, remaining, overlayDisplayed } = this; - const label = !overlayDisplayed ? null : 'Gated'; - console.log('label: ', label) window.p1events('track', { category: 'Content Meter', action, - ...(label && { label }), + ...(!overlayDisplayed && { label: 'Gated' }), props: { n: views }, }); this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); From f800a0a5f89f32064d20f67913ee43892e100143 Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 11:50:45 -0600 Subject: [PATCH 7/8] Remove the !not --- .../marko-web-theme-monorail/browser/content-meter-track.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index 620be23e8..435a937ba 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -81,7 +81,7 @@ export default { window.p1events('track', { category: 'Content Meter', action, - ...(!overlayDisplayed && { label: 'Gated' }), + ...(overlayDisplayed && { label: 'Gated' }), props: { n: views }, }); this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); From ec1d74dad94122125209389e3f6ff881e86d9158 Mon Sep 17 00:00:00 2001 From: Brian Miller Date: Mon, 2 Dec 2024 11:52:56 -0600 Subject: [PATCH 8/8] remove event emit --- .../marko-web-theme-monorail/browser/content-meter-track.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/marko-web-theme-monorail/browser/content-meter-track.vue b/packages/marko-web-theme-monorail/browser/content-meter-track.vue index 435a937ba..1c9bbb00c 100644 --- a/packages/marko-web-theme-monorail/browser/content-meter-track.vue +++ b/packages/marko-web-theme-monorail/browser/content-meter-track.vue @@ -77,14 +77,13 @@ export default { methods: { emitP1Event({ action }) { if (!window.p1events) return; - const { views, remaining, overlayDisplayed } = this; + const { views, overlayDisplayed } = this; window.p1events('track', { category: 'Content Meter', action, ...(overlayDisplayed && { label: 'Gated' }), props: { n: views }, }); - this.EventBus.$emit(`identity-x-content-meter-${action}`, { payload: { views, remaining, overlayDisplayed }}); }, }, };