Skip to content

google auth uri spec query re: falsy strings #17

@SignpostMarv

Description

@SignpostMarv

The code for generating the qrcode message makes quick checks to see if a string is "falsy", presumably intending to check if it's empty.

This means that a $label or $issuer of '' is treated identically to '0' and ' '.

How is trailing whitespace meant to be handled in these uris- i.e. should it be simply checking '' !== $label, or trim them first?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions