[Bug] PNG-N64 bug

[Catrious]

Describe the bug
If i convert a PNG to a N64 game, the emulator will boot it up but show a white screen

To Reproduce
Steps to reproduce the behavior:

1. Convert a PNG to a N64 file
2. Run the N64 file in a emulator like Simple64

Expected behavior
I expected it to load the image in the emu.

Desktop (please complete the following information):

• OS: Windows 11
• Browser Opera GX
• Version 127

[Coleisforrobot]

The code looks like it's working as intended but "as intended" doesn't seem to match expectations in the readme. It isn't creating a binary to render the image, it's treating the image as a binary waterfall in a specialised format (presumably for some need of the N64 ROM format)

Literally what it's doing is converting N64 ROMS into a specialised form of binary waterfall (take 4 bytes, put first 3 into R G and B values of pixel, then byte 4 goes into R of next pixel and set the G and B to 0, then repeat with next 4 bytes), using canvas to render that as a png, then when converting back from png it makes no checks if the image actually contains binary data and just reverses the steps.

I don't know anything about how N64 binaries work but my intuition is that it seems pretty impossible to create a file which renders an image without compiling it in the browser, and depending on their max size it could be difficult to do so without some form of compression or resizing.

I'm unsure how it should be communicated to a user that it doesn't convert actual image data to an N64 ROM. Perhaps the functionality could be merged into rgba.ts (I'm not 100% sure on what it does but iirc it creates binary waterfall-type images)? The conversion between different format N64 ROMs is useful but without any way to convert to or from any other format as it is it's probably not fit for here. @p2r3?

[omega-fallon]

The code looks like it's working as intended but "as intended" doesn't seem to match expectations in the readme. It isn't creating a binary to render the image, it's treating the image as a binary waterfall in a specialised format (presumably for some need of the N64 ROM format)

Literally what it's doing is converting N64 ROMS into a specialised form of binary waterfall (take 4 bytes, put first 3 into R G and B values of pixel, then byte 4 goes into R of next pixel and set the G and B to 0, then repeat with next 4 bytes), using canvas to render that as a png, then when converting back from png it makes no checks if the image actually contains binary data and just reverses the steps.

I don't know anything about how N64 binaries work but my intuition is that it seems pretty impossible to create a file which renders an image without compiling it in the browser, and depending on their max size it could be difficult to do so without some form of compression or resizing.

I'm unsure how it should be communicated to a user that it doesn't convert actual image data to an N64 ROM. Perhaps the functionality could be merged into rgba.ts (I'm not 100% sure on what it does but iirc it creates binary waterfall-type images)? The conversion between different format N64 ROMs is useful but without any way to convert to or from any other format as it is it's probably not fit for here. @p2r3?

rgba.ts doesn't create binary waterfalls, it just handles raw color sample data. The .rgb and .rgba formats are nothing more than pixel samples in groups of 3 or 4 bytes respectively.