From a4ad824a0d7cc2bb3eb9a4ac4fb6c749bc6aaca2 Mon Sep 17 00:00:00 2001 From: Nguyen Ngoc Cuong Date: Wed, 29 Mar 2023 18:07:05 +0700 Subject: [PATCH] Fix count(null) for php 8 When can't count($roles ) when is null --- controllers/customize.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/controllers/customize.php b/controllers/customize.php index 92e2978..9279ba3 100644 --- a/controllers/customize.php +++ b/controllers/customize.php @@ -268,7 +268,7 @@ public function addForum() $groupDto->description = $groupDescription; $groupDto->order = $forumService->getNewGroupOrder($sectionDto->id); $groupDto->isPrivate = (bool) $isPrivate; - $groupDto->roles = count($roles) ? json_encode($roles) : null; + $groupDto->roles = ($roles !== null) ? json_encode($roles) : null; $forumService->saveOrUpdateGroup($groupDto); @@ -366,7 +366,7 @@ public function editGroup() $groupDto->name = $groupName; $groupDto->description = $groupDescription; $groupDto->isPrivate = (bool) $isPrivate; - $groupDto->roles = count($roles) ? json_encode($roles) : null; + $groupDto->roles = ($roles !== null) ? json_encode($roles) : null; $forumService->saveOrUpdateGroup($groupDto); @@ -564,4 +564,4 @@ private function generateEditGroupForm( $action ) return $form; } -} \ No newline at end of file +}