From 62c543989c744ea59005165d50e086703691faf5 Mon Sep 17 00:00:00 2001 From: Daniel Trnka Date: Wed, 18 Mar 2026 23:43:49 +0100 Subject: [PATCH 1/3] fix: ast/message_id: use 0x1FFF_FFFF (1<<29 - 1) instead of 2^29 in test Clippy now emits the warning: error: using decimal literal for bitwise operation --> src/ast/message_id.rs:80:42 | 80 | let id = MessageId::Extended(2 ^ 29); | ^^ | = help: use binary (0b1_1101), hex (0x001d), or octal (0o35) notation for better readability = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#decimal_bitwise_operands = note: `-D clippy::decimal-bitwise-operands` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::decimal_bitwise_operands)]` The test should rather test 0x1FFF_FFFF (1<<29 - 1) instead of 2 XOR 29 (31) --- src/ast/message_id.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ast/message_id.rs b/src/ast/message_id.rs index da93ee8..7923dc0 100644 --- a/src/ast/message_id.rs +++ b/src/ast/message_id.rs @@ -77,8 +77,10 @@ mod tests { fn extended_message_id_raw() { let id = MessageId::Extended(2); assert_eq!(id.raw(), 2 | 1 << 31); - let id = MessageId::Extended(2 ^ 29); - assert_eq!(id.raw(), 2 ^ 29 | 1 << 31); + + // test with all 29 bits set + let id = MessageId::Extended(0x1FFF_FFFF); + assert_eq!(id.raw(), 0x1FFF_FFFF | 1 << 31); } #[test] From 3f69c2eae5c563cfcec4643df7e316cb3fe6fc9a Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Fri, 20 Mar 2026 01:15:33 -0400 Subject: [PATCH 2/3] Update src/ast/message_id.rs --- src/ast/message_id.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ast/message_id.rs b/src/ast/message_id.rs index 7923dc0..72492eb 100644 --- a/src/ast/message_id.rs +++ b/src/ast/message_id.rs @@ -80,7 +80,7 @@ mod tests { // test with all 29 bits set let id = MessageId::Extended(0x1FFF_FFFF); - assert_eq!(id.raw(), 0x1FFF_FFFF | 1 << 31); + assert_eq!(id.raw(), 0b10011111_11111111_11111111_11111111); } #[test] From fc1009ce4f553b774d99dadc2e562eef06776616 Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Fri, 20 Mar 2026 01:17:16 -0400 Subject: [PATCH 3/3] lint --- src/ast/message_id.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ast/message_id.rs b/src/ast/message_id.rs index 72492eb..6b87e6b 100644 --- a/src/ast/message_id.rs +++ b/src/ast/message_id.rs @@ -74,6 +74,7 @@ mod tests { use crate::MessageId; #[test] + #[expect(clippy::unreadable_literal)] fn extended_message_id_raw() { let id = MessageId::Extended(2); assert_eq!(id.raw(), 2 | 1 << 31);