-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathChangeLog
More file actions
7523 lines (4729 loc) · 250 KB
/
ChangeLog
File metadata and controls
7523 lines (4729 loc) · 250 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2009-11-24 21:21 John Beranek <jberanek@users.sourceforge.net>
* [r1269] web/auth_ldap.inc, web/mysql.inc, web/mysqli.inc,
web/version.inc:
* Fixed LDAP auth method so that $ldap_filter will work if you
use $ldap_dn_search_attrib.
* Updated 'mysql' and 'mysqli' DB abstractions to request a UTF-8
client charset if $unicode_encoding is true.
* Updated version number to 1.4.3.
2009-11-14 21:35 John Beranek <jberanek@users.sourceforge.net>
* [r1268] web/systemdefaults.inc.php:
* Added code to disable the E_DEPRECATED error class, due to our
use of the 'is_dst' option in mktime() being deprecated in PHP >=
5.3.0.
2009-11-14 20:56 John Beranek <jberanek@users.sourceforge.net>
* [r1267] web/auth_imap.inc:
* Fixed a regular expression used for IMAP quoting, received as a
patch from Thomas Bleher.
2009-11-13 21:09 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1264] web/edit_users.php:
Fixed a bug which prevented users from being edited (unless they
happened to be the user with id 0)
2009-11-09 21:27 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1243] tables.pg.sql:
Updated the db version number.
2009-11-08 10:32 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1241] web/edit_users.php:
Added an id to a form so that sites can add their own styling.
2009-11-04 16:01 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1240] web/config.inc.php:
Added comment to steer admins toward the lang files if they want
to change some of the text strings.
2009-11-03 15:23 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1239] web/mrbs_sql.inc, web/site_faq.html:
- changed behaviour of monthly and yearly repeats so that if a
day does not exist in the month (eg 29/30/31) MRBS will use the
last day of the month (instead of going forward into the next
month as it did before) - updated Help text to reflect new
monthly and yearly repeat behaviour - updated Help text to
reflect existing monthly, corresponding day behaviour (ie using
29/30/31 is valid and is useful) - combined logic for weekly and
n-weekly repeats: a weekly repeat is just a special case of an
n-weekly repeat - simplified fix introduced in Rev 1236 now that
we can rely on at least one repeat day being set for weekly and
n-weekly repeats (see Rev 1238)
2009-11-03 14:25 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1238] web/edit_entry_handler.php:
Fixed bug introduced in Rev 1237 that caused n-weekly repeats to
get stuck in an infinite loop (the code assumes that at least one
repeat day has been set).
2009-11-02 15:00 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1237] web/edit_entry.php, web/edit_entry_handler.php:
Removed the checks that tested whether at least one repeat day
had been checked in the case of weekly and n-weekly repeats. The
checks were not necessary because if no repeat days are checked,
MRBS assumes that the repeat day is the day of the week of the
start of the period (as indeed it says in the Help text).
2009-11-02 14:44 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1236] web/mrbs_sql.inc:
Fixed a bug which meant that for weekly and n-weekly bookings the
first day of the period was booked when it should not have been
because one or more of the repeat days had been checked - but not
the day of the week of the start of the period. For example if
you request a weekly repeat from 1-30 November 2009 for
Thursdays, then the 1 Nov was also being booked when it should
not have been because it's a Sunday. (Problem reported by Randy
Allen on the general mailing list).
2009-11-01 20:13 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1235] web/edit_area_room.php:
- altered the behaviour of edit_area_room.php so that after
you've edited a room or an area you are returned to the admin
page, rather than staying on the edit_area_room.php page. - fixed
a bug which resulted in invalid HTML and an incorrectly rendered
page when editing an area and using periods
2009-10-31 23:23 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1234] web/edit_users.php:
Removed stray blank line.
2009-10-31 18:48 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1233] web/edit_users.php, web/lang.en:
Improved the error handling when adding a new user, so that form
data is reloaded if there is an error and does not have to be
re-typed by the user.
2009-10-27 23:28 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1232] web/lang.fr:
Added "area" token
2009-10-27 16:52 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1231] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql,
web/add.php, web/admin.php, web/day.php, web/dbsys.inc,
web/edit_area_room.php, web/edit_entry.php, web/functions.inc,
web/lang.en, web/month.php, web/report.php, web/upgrade/8,
web/upgrade/8/mysql.sql, web/upgrade/8/pgsql.sql,
web/upgrade/8/post.inc, web/week.php:
Added a sort key for rooms, so that rooms can be sorted in an
order defined by the administrator rather than alphabetically. By
default the sort key is the same as the room name and rooms will
be sorted alphabetically as before. The sort order applies
whenever rooms are listed, eg in the main day view and in
drop-down lists.
2009-10-22 16:21 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1230] web/search.php:
Added error checking after the first SQL query. (Although there
is some error checking after the second query, it is never
reached if there's an error in the SQL predicate, or the first
SQL query generally, and MRBS just incorrectly reports that there
are no entries matching the search string).
2009-10-22 16:16 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1229] web/report.php:
Changed capitalisation of table aliases in the SQL query to be
consistent with search.php. No functional change to MRBS.
2009-10-22 12:59 John Beranek <jberanek@users.sourceforge.net>
* [r1228] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql:
* Updated DB schema number in the instalation SQL files.
2009-10-21 21:44 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1227] web/search.php:
- Ensured that searches respect the per-area privacy settings -
Fixed bug which meant that searches did not work on PostgreSQL
when users were not admins and $private_override was not set to
public
2009-10-21 21:39 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1226] web/report.php:
- Ensured that reports respect the per-area privacy settings -
Fixed bug which meant that (depending on their name) admins would
not be recognised as having admin rights, and so would not see
private bookings made by other users
2009-10-21 20:43 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1225] web/add.php, web/dbsys.inc, web/upgrade/7,
web/upgrade/7/mysql.sql, web/upgrade/7/pgsql.sql,
web/upgrade/7/post.inc:
Ensured that the private settings in the area table are always
not NULL, by converting existing areas and setting the private
fields when creating new areas. (It will make ensuring that
Search and Report respect the private settings easier if the
settings can be guaranteed to be not NULL).
2009-10-21 18:26 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1224] web/view_entry.php:
Fix to ensure that view_entry uses the per-area privacy settings
(problem reported by David Moore on the general mailing list).
Still to come: fixes for Search and Report which suffer from a
similar problem.
2009-10-20 11:51 John Beranek <jberanek@users.sourceforge.net>
* [r1223] web/config.inc.php:
* Removed odd stray spaces from the config file.
2009-10-20 11:49 John Beranek <jberanek@users.sourceforge.net>
* [r1222] web/auth_imap.inc, web/escapeshellarg.inc, web/month.php,
web/session_cookie.inc, web/session_php.inc, web/week.php:
* Replaced all usage of ereg_replace() with calls to
preg_replace() for consistency and because PHP 5.3 has deprecated
the function.
2009-10-18 16:02 John Beranek <jberanek@users.sourceforge.net>
* [r1221] web/language.inc:
* Fix for setting UTF-8 locale on BSD (and Linux). It turns out
Linux is also happy to specify a UTF-8 locale with ".UTF-8" in
upper case. Fix provided by Ian Rees in SF tracker #2859067.
2009-10-18 15:35 John Beranek <jberanek@users.sourceforge.net>
* [r1220] web/session_remote_user.inc, web/systemdefaults.inc.php:
* Patch from Emmanuel Dreyfus to add a configuration variable to
configure a login link for the "remote_user" authentication
scheme.
2009-10-18 15:30 John Beranek <jberanek@users.sourceforge.net>
* [r1219] web/functions.inc, web/systemdefaults.inc.php:
* Patch from Emmanuel Dreyfus to add a config variable to force
the booking resolution to the value of $resolution, rather than
the resolution for the area set in the database.
2009-10-18 15:25 John Beranek <jberanek@users.sourceforge.net>
* [r1218] web/mrbs_auth.inc, web/systemdefaults.inc.php:
Slight variation on a patch from Emmanuel Dreyfus (changed
variable name)
2009-10-08 06:16 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1217] web/lang.fr, web/report.php:
- Reverted Revision 1211 (ie put entities back in) -
entities are now replaced in the CSV report header row
using mrbs_entity_decode()
2009-10-07 15:20 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1216] web/functions.inc, web/functions_mail.inc:
- Added an mrbs_entity_decode() function - Extended removal of
entities in period names in mail messages to PHP4 and
below.
2009-10-02 10:05 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1212] web/language.inc:
Changed name of optional third parameter in utf8_substr() from
$end to $length to make it less confusing.
2009-10-01 23:22 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1211] web/lang.fr:
Changed to an ordinary space (except where there are two
of them) - otherwise they appear as is in CSV report headers.
2009-10-01 22:57 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1210] web/report.php:
Changed Content-type for CSV reports to text/csv and added a
charset to aid internationalisation. (Note that Excel does not
open CSV files properly. To open a UTF-8 file in Excel, save it
as a .txt file first and then specify the charset in the dialogue
that appears when you open the file in Excel).
2009-10-01 22:46 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1209] web/Themes/default/header.inc, web/language.inc,
web/style.inc:
Introduced a get_charset() function. No functional change to
MRBS.
2009-09-27 17:14 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1206] web/functions_mail.inc:
Further simplified the code in getPreviousEntryData(). No
functional change to MRBS.
2009-09-27 16:13 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1205] web/edit_entry.php:
Fixed a bug which meant that the number of weeks wasn't shown in
the form when editing an existing n-weekly booking.
2009-09-27 16:07 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1204] web/functions_mail.inc:
Fixed a (very minor!) bug that meant that $weekstarts was ignored
in email notifications and repeat entries covering more than one
day of the week were listed starting at the wrong place. For
example if $weekstarts=1 (ie Mon) and a weekly repeat is made for
Sat and Sun, the email notification listed them as Sun, Sat
instead of Sat, Sun.
2009-09-27 15:54 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1203] web/functions_mail.inc:
Simplified the code in getPreviousEntryData(). No functional
change to MRBS.
2009-09-25 08:46 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1202] web/report.php, web/systemdefaults.inc.php:
Converted CSV constants into variables, so that they can be
redefined in config.inc.php
2009-09-24 17:36 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1201] web/systemdefaults.inc.php:
Corrected constant definitions used for CSV reports.
2009-09-23 15:12 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1200] web/lang.en, web/report.php, web/systemdefaults.inc.php:
Added the ability to output reports and summaries as CSV files.
2009-09-17 15:25 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1199] web/systemdefaults.inc.php:
Tried to make the language settings slightly clearer. No
functional change to MRBS.
2009-09-15 22:12 John Beranek <jberanek@users.sourceforge.net>
* [r1198] web/language.inc:
* Added support for Bulgarian localisation
2009-09-11 14:29 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1197] web/mrbs-ie.css:
Minor change to formatting of the edit_user form to improve looks
(added some more space below the form legend for IE, as IE by
default leaves none)
2009-09-08 15:52 dceschools
* [r1195] web/systemdefaults.inc.php:
Add unset to array variables in systemdefaults.inc.php so they
can be copied to config.inc.php if needed.
2009-09-04 11:56 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1192] web/mrbs.css.php:
Fixed a problem which caused the highlight colour to shine
through bookings that have an opacity of less than 1 (eg private
bookings) when they occur in cells in the day and week views that
have multiple bookings.
2009-09-03 23:26 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1191] web/edit_area_room.php:
Changed event handlers for the radio buttons to be onClick rather
than onChange (the onChange handler shouldn't fire until the
control loses focus - correctly implemented on IE but not on FF).
2009-09-03 13:49 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1189] web/day.php, web/month.php:
Changed SQL ORDER BY clauses to use column names rather than
column positions in order to improve maintainability. No
functional change to MRBS.
2009-09-03 13:31 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1188] web/report.php:
Changed SQL ORDER BY clauses to use column names rather than
column positions in order to improve maintainability. No
functional change to MRBS.
2009-09-03 13:17 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1187] web/report.php:
Minor change to bring into line with MRBS coding conventions.
2009-08-28 15:09 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1181] web/functions.inc, web/functions_mail.inc:
Corrected use of version_compare()
2009-08-28 14:01 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1180] web/session_cookie.inc, web/session_http.inc,
web/session_php.inc, web/session_remote_user.inc:
Fixed the display in the header ("You are <user>") of usernames
that contain html special chars.
2009-08-28 13:50 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1179] web/view_entry.php:
Fixed bug which meant that a user could not see their own private
bookings if the user name contained HTML special chars.
2009-08-26 23:26 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1178] web/functions_mail.inc:
Fixed a bug which meant that when using periods, any HTML
entities or tags in the period name string (which are allowed)
were left as is in email notifications, which are sent as plain
text emails. (HTML entities are only replaced in PHP5 and above,
to avoid any complications with lack of support for multi-byte
character sets).
2009-08-24 09:06 John Beranek <jberanek@users.sourceforge.net>
* [r1177] web/pgsql.inc:
* Improved/fixed the PostgreSQL sql_table_exists()
implementation.
2009-08-23 18:13 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1175] tables.pg.73and_above.sql, tables.pg.sql:
Removed duplicate primary key declaration from users table.
2009-08-12 14:06 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1174] web/view_entry.php:
Fixed bug causing undefined variable notice when an email
notification of a series is viewed. (The notice is only visible
in MRBS if error_reporting is set to include Notices).
2009-08-11 14:11 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1173] web/config.inc.php:
Addition of comment.
2009-08-11 14:05 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1172] web/systemdefaults.inc.php, web/theme.inc:
Moved consistency checking of user settings for periods and time
slots out of systemdefaults.inc.php where it is now unnecessary
(because systemdefaults.inc.php cannot be changed by the user)
and put it into theme.inc.
2009-08-11 12:33 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1171] web/config.inc.php, web/del_entry.php,
web/edit_entry_handler.php, web/functions_mail.inc,
web/language.inc, web/systemdefaults.inc.php, web/theme.inc:
- Changed the constants in systemdefaults.inc.php to variables,
as constants can only be defined once, meaning they cannot be
redefined in config.inc.php (IS_XHTML should remain a constant
though as that is not intended to be redefined in config.inc.php)
- Resolved the Catch-22 (reported by Thomas Bleher on the mailing
list) which prevented language settings from being defined in
config.inc.php
2009-08-05 22:36 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1170] web/edit_entry.php:
Fixed very minor problem (not normally visible to the user) that
caused an 'undefined' error in JavaScript when there are no rooms
defined for an area.
2009-08-05 15:52 John Beranek <jberanek@users.sourceforge.net>
* [r1169] web/search.php:
* Added missing SQL escaping for $user in search.php, this
variable is not directly enterable by a user, so the issue was of
a lesser consequence.
2009-08-01 21:05 John Beranek <jberanek@users.sourceforge.net>
* [r1168] web/mincals.inc, web/mrbs.css.php,
web/systemdefaults.inc.php:
* Implemented new config variable, $mincals_week_numbers. If this
is set to true, week numbers will be shown in the mini-calendars.
The numbers will only be accurate if you set $weekstarts to 1.
2009-07-22 13:30 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1167] web/mrbs.css.php:
Fixed a bug introduced in Revision 1123 which meant that the
empty cells in the month view were no longer clickable.
2009-07-22 09:52 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1166] web/Themes/default/header.inc:
Added declaration of $PHP_SELF to avoid problems when using
versions of PHP < 4.1.0
2009-07-21 16:20 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1165] web/session_http.inc:
Fixed problem with the TargetURL being undefined and causing
badly formed HTML when Notice errors are turned on. (However the
problem still exists that when using HTTP sessions MRBS will
redirect to the admin page on login, rather than the current
page. I haven't tried to fix this.)
2009-07-21 15:02 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1164] web/session_cookie.inc, web/session_php.inc:
Removed redundant declarations of $auth
2009-07-21 14:48 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1163] web/session_cookie.inc, web/session_php.inc:
Removed references to redundant variable $user_link
2009-07-21 14:43 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1162] web/session_http.inc, web/session_remote_user.inc:
Fixed bug that caused query string to be missing parameter values
for day, month and year in the "You are user" link in the header
in the http and remote_user session schemes. (Didn't affect
functionality as search.php was resilient, but it caused
undefined variable notices when running with notices turned on).
2009-07-20 16:23 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1161] web/edit_entry.php, web/report.php, web/search.php:
Brought commenting style into line with MRBS standard practice.
2009-07-17 19:59 John Beranek <jberanek@users.sourceforge.net>
* [r1160] web/config.inc.php:
* Tweaked capitalisation of warning in config.inc.php.
2009-07-17 19:52 John Beranek <jberanek@users.sourceforge.net>
* [r1159] web/upgrade.inc:
* Fixed error reporting in DB upgrade mechanism.
2009-07-16 16:03 John Beranek <jberanek@users.sourceforge.net>
* [r1158] web/defaultincludes.inc:
* Added $Id$ to new file, defaultincludes.inc.
2009-07-16 15:56 John Beranek <jberanek@users.sourceforge.net>
* [r1157] checklang.php, convert_db_to_utf8.php, testdata.php,
web/add.php, web/admin.php, web/config.inc.php, web/day.php,
web/defaultincludes.inc, web/del.php, web/del_entry.php,
web/edit_area_room.php, web/edit_entry.php,
web/edit_entry_handler.php, web/edit_users.php, web/help.php,
web/index.php, web/month.php, web/mrbs-ielte7.css.php,
web/mrbs.css.php, web/report.php, web/search.php,
web/systemdefaults.inc.php, web/view_entry.php, web/week.php:
* Moved default configuration out of config.inc.php into
systemdefaults.inc.php. Users should _not_ modify
systemdefaults.inc.php and instead add lines into config.inc.php.
* Created defaultincludes.inc, which includes the 6 standard
files that pages include. Most pages include this.
2009-07-15 23:11 John Beranek <jberanek@users.sourceforge.net>
* [r1155] web/version.inc:
* Updated version number post release of 1.4.2.
2009-07-15 22:46 John Beranek <jberanek@users.sourceforge.net>
* [r1153] ChangeLog, NEWS:
* Updated NEWS/ChangeLog for MRBS 1.4.2 release.
2009-07-15 22:36 John Beranek <jberanek@users.sourceforge.net>
* [r1152] web/version.inc:
* Updated version number for 1.4.2 release.
2009-07-14 08:58 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1151] web/dbsys.inc, web/upgrade.inc:
Fixed problem that meant that the correct database connection
wasn't being used when upgrading the database (ie MRBS was using
the ordinary username/password specified in the config file
rather than the admin username/password entered during the
upgrade process).
2009-07-08 12:04 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1150] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql:
Updated comments to reflect the new definition of maximum field
lengths in the config file.
2009-07-08 12:01 John Beranek <jberanek@users.sourceforge.net>
* [r1149] web/config.inc.php:
* Small typo fix in a comment in the new $maxlength array values
in config.inc.php.
2009-07-08 11:55 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1148] web/add.php, web/admin.php, web/config.inc.php:
Added checking of lengths for room description in order to avoid
SQL errors in PostgreSQL.
2009-07-08 10:56 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1147] web/config.inc.php, web/edit_users.php:
Added checking of name lengths for username and email address in
order to avoid SQL errors in PostgreSQL.
2009-07-08 09:40 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1146] web/add.php, web/admin.php, web/config.inc.php,
web/edit_entry.php, web/edit_entry_handler.php:
Added checking of name lengths for room and area names in order
to avoid SQL errors in PostgreSQL.
2009-07-03 20:07 John Beranek <jberanek@users.sourceforge.net>
* [r1145] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql:
* Updated comments at the top of the table definition SQL files,
to tell people to update the 'INSERT INTO' lines too, if they
change the table prefix.
2009-07-02 09:12 John Beranek <jberanek@users.sourceforge.net>
* [r1143] ChangeLog, NEWS:
* Updated NEWS and ChangeLog for MRBS 1.4.2 release.
2009-07-02 08:25 John Beranek <jberanek@users.sourceforge.net>
* [r1142] web/version.inc:
* Updated version number to 1.4.2rc1.
2009-06-29 12:03 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1141] web/auth_db.inc, web/config.inc.php,
web/upgrade/6/post.inc:
- Changed the Upgrade 6 procedure so that it populates the users
table with admins at $max_level instead of 2.
- Moved the definition of $max_level and $min_user_editing_level
out of auth_db.inc and into config.inc.php
2009-06-29 11:39 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1140] web/upgrade/6/post.inc:
Fixed an existing problem where the default value fr the level
column is set to 1 instead of 0 in the case that the users table
already exists.
2009-06-29 10:58 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1139] web/upgrade.inc:
Added fix to prevent warning message from fread() if file size is
0.
2009-06-29 09:59 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1138] web/dbsys.inc:
Minor update to comments.
2009-06-28 20:29 John Beranek <jberanek@users.sourceforge.net>
* [r1137] web/upgrade/6/post.inc:
* Fixed put in DV schema version 6 post.inc - was using a MySQL
specific DB function rather than the abstracted function. Made
PostgreSQL bomb out instead of complete correctly.
2009-06-28 19:14 John Beranek <jberanek@users.sourceforge.net>
* [r1136] web/dbsys.inc, web/upgrade.inc, web/upgrade/5/pgsql.sql,
web/upgrade/6/pgsql.sql:
* Improved error handing in DB upgrade system. If any errors are
encountered, the upgrade process is now immediately stopped.
* Fixed version 5 and 6 schema upgrades for PostgreSQL, it didn't
like being sent SQL with just a comment.
2009-06-26 14:46 John Beranek <jberanek@users.sourceforge.net>
* [r1135] web/upgrade/6/post.inc:
* Fixed bracketing in sql_query() call in db schema 6 post.inc,
though it shouldn't in fact make any difference.
2009-06-26 14:08 John Beranek <jberanek@users.sourceforge.net>
* [r1134] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql,
web/dbsys.inc, web/edit_users.php, web/upgrade/5/pgsql.inc[DEL],
web/upgrade/5/pgsql.sql[CPY], web/upgrade/6,
web/upgrade/6/mysql.sql, web/upgrade/6/pgsql.sql,
web/upgrade/6/post.inc:
* Moved code to add the 'level' column into the mrbs_users table
out of edit_users.php and into DB schema version 6 upgrade code.
* Fixed the name of the PostgreSQL upgrade SQL file for schema
version 5.
2009-06-25 22:52 John Beranek <jberanek@users.sourceforge.net>
* [r1133] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql:
* Added missing DB schema version 4 changes to initial table
creation SQL files.
2009-06-25 22:36 John Beranek <jberanek@users.sourceforge.net>
* [r1132] tables.my.sql:
* Created syntax for creation of mrbs_users for MySQL.
2009-06-25 22:33 John Beranek <jberanek@users.sourceforge.net>
* [r1131] tables.my.sql, tables.pg.73and_above.sql, tables.pg.sql,
web/dbsys.inc, web/edit_users.php, web/upgrade/5,
web/upgrade/5/mysql.sql, web/upgrade/5/pgsql.inc,
web/upgrade/5/post.inc:
* Moved creation of mrbs_users table into the SQL schema update
number 5.
2009-06-25 19:36 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1130] web/dbsys.inc, web/lang.en, web/mrbs.css.php,
web/mysql.inc, web/mysqli.inc, web/pgsql.inc, web/upgrade.inc:
Changed the authentication scheme for database upgrades so that
instead of requiring the user to be logged in as an MRBS admin,
the system now asks for a database username and password with
admin rights. This has the advantages that (a) the database
username and password supplied in the config file need only have
ordinary user rights* and (b) it prevents the Catch 22 situation
when upgrading the users table (you can't upgrade the database
until you've logged in as an admin, but you can't log in as an
admin until you've upgraded the database).
[*Note though that if using the db authentication scheme, the
users table is still altered using the standard database username
supplied in the config file. This still needs to be changed to
use the standard upgrade mechanism]
2009-06-24 15:47 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1129] web/config.inc.php, web/dbsys.inc,
web/edit_area_room.php, web/functions.inc, web/lang.en,
web/mrbs-ie.css, web/mrbs-ie8.css, web/mrbs.css.php,
web/upgrade/4, web/upgrade/4/mysql.sql, web/upgrade/4/pgsql.sql,
web/upgrade/4/post.inc:
Made the private bookings config editable per-area, with the
config variables being the default settings to be used when a new
area is created.
2009-06-23 15:02 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1128] web/mrbs.css.php:
Fixed bug introduced in Rev 1123 which stopped the display of
minimised multiple bookings working properly in IE8.
2009-06-23 14:35 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1127] web/Themes/classic126/styling.inc,
web/Themes/default/styling.inc, web/functions.inc, web/lang.en,
web/month.php, web/mrbs-ielte8.css, web/mrbs.css.php,
web/style.inc, web/view_entry.php:
- Added a class for private bookings so that they can be styled
using that class, rather than by defining extra booking types.
The default styling is for the opacity of the cell to be set to
0.6 (ie they are slightly washed out versions of public bookings)
and the text to be in italics. Note that the opacity changes do
not show up in IE because its support for opacity is
temperamental, but the italic font will still show up and the
font colour is also lightened to simulate the opacity change.
- Added colour coding of private bookings to the month view (and
used the same opacity/italic treatment as in the day and week
views).
- Minor changes to default text for private bookings
2009-06-23 11:35 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1126] web/report.php:
Fixed report SQL following change of PostgreSQL type for private
from boolean to smallint.
2009-06-23 10:48 John Beranek <jberanek@users.sourceforge.net>
* [r1125] web/auth_ldap.inc:
* Added check for LDAP support into auth_ldap.inc - based on a
suggestion from Chris Cook.
2009-06-22 22:56 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1124] web/edit_area_room.php:
Added checks for zero values of Resolution in order to avoid
divide by zero errors and endless loops.
2009-06-22 22:06 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1123] web/config.inc.php, web/mrbs-ielte7.css[DEL],
web/mrbs-ielte7.css.php[CPY], web/mrbs.css.php, web/style.inc:
Fixed a problem (reported as SF Feature Request 249087) which
meant that if $clipped is set to FALSE, then empty cells are no
longer clickable. (The fix isn't a perfect fix, but at least
means that the system is usable when $clipped is set to FALSE. In
particular the fix doesn't work on IE6 and IE7 and so for those
browsers $clipped is ignored and assumed to be TRUE. For other
browsers, empty cells are only clickable in the top section - ie
if one of the cells in a row is stretched because the content is
too large for the cell, then the empty cells are only clickable
in the standard height portion - and bookings are only clickable
for the height of the text rather than over the whole cell.
2009-06-19 21:58 John Beranek <jberanek@users.sourceforge.net>
* [r1122] web/report.php, web/search.php:
* Removed unnecessary SQL escaping. When
sql_syntax_caseless_contains() is used you don't need to use
addslashes() as sql_syntax_caseless_contains() escaping the
string itself. Added notes to this effect where
sql_syntax_caseless_contains() is used.
2009-06-19 21:10 John Beranek <jberanek@users.sourceforge.net>
* [r1121] web/edit_users.php, web/mrbs_sql.inc:
* Added more missing SQL escaping.
2009-06-19 20:50 John Beranek <jberanek@users.sourceforge.net>
* [r1120] web/search.php:
* Added missing SQL escaping to search functionality.
2009-06-19 20:45 John Beranek <jberanek@users.sourceforge.net>
* [r1119] web/report.php:
* Added SQL escaping in reports (Secunia Advisory SA35469).
2009-06-18 21:54 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1118] web/edit_entry_handler.php:
Truncated the name field to the maximum length as a precaution.
Although the MAXLENGTH attribute is used in the <input> tag, this
can sometimes be ignored by the browser, for example by Firefox
when autocompletion is used. The user could also edit the HTML
and remove the MAXLENGTH attribute. Passing an oversize string to
some databases (eg some versions of PostgreSQL) results in an SQL
error, rather than silent truncation of the string.
2009-06-17 14:48 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1117] tables.pg.73and_above.sql, tables.pg.sql,
web/mrbs_sql.inc, web/upgrade/3/pgsql.sql:
Converted the 'private' field in the entry and repeat tables from
a boolean to a smallint for PostgreSQL implementations.
PHP returns PostgreSQL boolean fields as strings, ie 't' or 'f'
which always evaluate to true without a lot of processing. This
means that entries are always considered to be private, whether
they really are or not. Although using smallints takes up more
space (2 bytes instead of 1 bit), it makes the code much simpler.
The upgrade SQL files have been retrospectively changed, ie no
attempt has been made to provide an Upgrade 4 file which converts
existing booleans to smallints. As MRBS fails immediately an
entry is created when using booleans and no reports of failure
have been seen, it seems unlikely that there are any existing
PostgreSQL implementations using a 1.4.1 + SVN version of MRBS.
If there are, the fields can always be converted using a
PostgreSQL admin tool.
2009-06-15 20:23 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1116] web/mrbs_sql.inc:
Fixed a problem that was causing PostgreSQL databases to complain
giving the error message "ERROR: column "private" is of type
boolean but expression is of type integer HINT: You will need to
rewrite or cast the expression".
2009-05-28 22:23 John Beranek <jberanek@users.sourceforge.net>
* [r1115] web/auth_db_ext.inc:
* Made backwards-compatibility special case in auth_db_ext.inc
more clear.
2009-05-22 13:56 John Beranek <jberanek@users.sourceforge.net>
* [r1113] web/auth_smtp.inc, web/config.inc.php:
* Added a new authentication method, auth_smtp.inc. Utilises the
Net_SMTP Pear package.
2009-05-19 17:54 dceschools
* [r1112] web/edit_entry.php:
Fixes problem of private booking details being exposed when
another user copies an existing hidden event. Private details are
now cleared when this happens.
2009-05-18 17:35 dceschools
* [r1111] web/mrbs_sql.inc:
Fixes problem of private booking details being exposed when there
is a scheduling conflict.
2009-05-14 16:20 Campbell Morrison <cimorrison@users.sourceforge.net>
* [r1110] web/edit_entry.php:
Fixed edit_entry form so that if a booking is being copied then