shouldn't OWLVarDecl *vars be const?
#207
bricerebsamen
started this conversation in
General
Replies: 2 comments
-
|
This is correct, the could (and arguably should) be declared const. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
PR #208 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In
owlGeomTypeCreate()owl/owl/impl.cpp
Line 903 in 056e8ff
OWLVarDecl *varsbe const since it's passed tocheckAndPackVariableswhich takes it as a const?Also, does this array need to remain valid after the call to
owlGeomTypeCreate()or can it be a temp variable? for now I have it as a static, which means that it should also be const...Beta Was this translation helpful? Give feedback.
All reactions