From be7dfdddc46055704615495ad5d2ae112fa07710 Mon Sep 17 00:00:00 2001 From: Paul Sterpu Date: Fri, 3 Oct 2025 09:34:45 +0300 Subject: [PATCH 1/3] fix: spider chart with variable data points Signed-off-by: Paul Sterpu --- .../src/charts/spider-chart/components/spider-chart.tsx | 9 ++++++--- packages/open-ui-kit/src/charts/spider-chart/index.ts | 5 ++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx b/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx index 79a8a35..6547f2b 100644 --- a/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx +++ b/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx @@ -78,6 +78,9 @@ export const SpiderChart = ({ ); }); + const angleStep = 360 / data.length; + const computedAngleOffset = 90 % angleStep; + return ( @@ -95,7 +98,7 @@ export const SpiderChart = ({ data={[{ subject: "1" }]} polarAngles={Array(data.length) .fill(0) - .map((_, i) => i * (360 / data.length) + tickBand)} + .map((_, i) => i * angleStep + tickBand)} /> i * (360 / data.length) + band)} + .map((_, i) => i * angleStep + computedAngleOffset)} /> i * (360 / data.length) + band)} + .map((_, i) => i * angleStep + computedAngleOffset)} /> {radars.map((radar, index) => ( diff --git a/packages/open-ui-kit/src/charts/spider-chart/index.ts b/packages/open-ui-kit/src/charts/spider-chart/index.ts index 2c9e95d..f410562 100644 --- a/packages/open-ui-kit/src/charts/spider-chart/index.ts +++ b/packages/open-ui-kit/src/charts/spider-chart/index.ts @@ -5,4 +5,7 @@ */ export { SpiderChart } from "./components/spider-chart"; -export type { SpiderChartProps } from "./types/spider-chart.types"; +export type { + SpiderChartProps, + ExtendedDataPoint, +} from "./types/spider-chart.types"; From c59e8a02c0a9649d45db9b211f857f2da8ebfdf4 Mon Sep 17 00:00:00 2001 From: Paul Sterpu Date: Fri, 3 Oct 2025 09:43:06 +0300 Subject: [PATCH 2/3] fix: lint Signed-off-by: Paul Sterpu --- .../src/charts/spider-chart/components/spider-chart.tsx | 1 - .../src/charts/spider-chart/types/spider-chart.types.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx b/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx index 6547f2b..8bcaadb 100644 --- a/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx +++ b/packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx @@ -45,7 +45,6 @@ const calculateDomain = (data: ExtendedDataPoint[]) => [ export const SpiderChart = ({ data, radars, - band = 30, tickBand = 5, scale = 1, outerRadius = 90, diff --git a/packages/open-ui-kit/src/charts/spider-chart/types/spider-chart.types.ts b/packages/open-ui-kit/src/charts/spider-chart/types/spider-chart.types.ts index e372b3a..4bec8fb 100644 --- a/packages/open-ui-kit/src/charts/spider-chart/types/spider-chart.types.ts +++ b/packages/open-ui-kit/src/charts/spider-chart/types/spider-chart.types.ts @@ -32,7 +32,6 @@ export type SpiderChartProps = { radars: RadarType[]; outerRadius?: number; padData?: number; - band?: number; onTooltipClick?: (subject: string) => void; tooltipContent?: (dataPoint: ExtendedDataPoint) => React.ReactNode; showTooltip?: boolean; From 140390bf24855ae17ce2006500c74c5590a024d3 Mon Sep 17 00:00:00 2001 From: Paul Sterpu Date: Fri, 3 Oct 2025 09:44:13 +0300 Subject: [PATCH 3/3] fix: storybook Signed-off-by: Paul Sterpu --- .../src/charts/spider-chart/stories/spider-chart.stories.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/open-ui-kit/src/charts/spider-chart/stories/spider-chart.stories.tsx b/packages/open-ui-kit/src/charts/spider-chart/stories/spider-chart.stories.tsx index a897341..d17b960 100644 --- a/packages/open-ui-kit/src/charts/spider-chart/stories/spider-chart.stories.tsx +++ b/packages/open-ui-kit/src/charts/spider-chart/stories/spider-chart.stories.tsx @@ -21,9 +21,6 @@ const meta: Meta = { outerRadius: { description: "The outer radius of the chart.", }, - band: { - description: "The outer radius of the chart", - }, onTooltipClick: { description: "Callback to call on tooltip click", },