Install with SSL false fails to generate valid

[dutchwhizzman]

Oct 29 13:26:22 hostname.tld nginx[25829]: nginx: [emerg] "location" directive is not allowed here in /etc/nginx/sites-enabled/nextcloud_server_main.conf:25

Basically, the server {} definition is closed before the location / {} is put in the file.

[othalla]

Thank you for reporting it @dutchwhizzman
i'll have a look!

[dutchwhizzman]

I have made some changes and improvements to get it working for me, want me to submit a push?

[othalla]

If you have the fix, you can make a PR yes !

[dutchwhizzman]

I found the root cause: voxpupuli/puppet-nginx#1142 You have to define ssl_only for the location part if you want it to be in the https server, if it's not defined, it refuses to put it in the ssl part of the server and puts it on top of the file. I thought I fixed it because I only tested the non https version. Now I started re-integrating https/certbot, I ran into the same thing again. Now, how to solve it...? You can't do if {} inside a definition....

…

On Thu, Nov 1, 2018 at 10:46 AM Florian CHARDIN ***@***.***> wrote: If you have the fix, you can make a PR yes ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmbKpqrgonSh17BQ6MJPVulRUlHQ4Kl_ks5uqsL2gaJpZM4X_Eid> .

[othalla]

Hum i see, maybe put the whole block in a if?

[dutchwhizzman]

Yeah, I have a split for the ssl/non-ssl part now and the root location. I still need to do the rest and test thoroughly before will create an updated pull request.

…

On Mon, Nov 5, 2018 at 6:05 PM Florian CHARDIN ***@***.***> wrote: Hum i see, maybe put the whole block in a if? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmbKptcehelqdJE-hp-pyA_hJHU3vkOeks5usG_MgaJpZM4X_Eid> .