Restrain move to same university websites

Author: pabois

app/controllers/concerns/admin/has_move_action.rb

@@ -2,7 +2,7 @@ module Admin::HasMoveAction
   extend ActiveSupport::Concern
 
   included do
-    before_action :ensure_access, :load_object, only: [:move, :do_move]
+    before_action :load_object, :load_target_websites, :ensure_access, only: [:move, :do_move]
   end
 
   def move
@@ -12,30 +12,31 @@ def move
   end
 
   def do_move
-    new_website = current_user.managed_websites.find(params[:new_website_id])
+    new_website = @target_websites.find(params[:new_website_id])
     redirect_to [:admin, @object], alert: t('admin.move.permission_denied') and return unless new_website
-    old_university = @object.university
-    new_university = new_website.university
+    redirect_to [:admin, @object], alert: t('admin.move.permission_denied') and return if new_website.university_id != @object.university_id
     @object.move_to!(new_website)
-    if old_university != new_university
-      redirect_to admin_communication_website_posts_path(new_website), notice: t('admin.move.successfully_moved', model: @object.to_s_in(current_language))
-    else
-      redirect_to [:admin, @object, website_id: new_website.id], notice: t('admin.move.successfully_moved', model: @object.to_s_in(current_language))
-    end
+    redirect_to [:admin, @object, website_id: new_website.id], notice: t('admin.move.successfully_moved', model: @object.to_s_in(current_language))
   end
 
   protected
-  
-  def ensure_access
-    unless can?(:move, @object) && current_user.managed_websites.count > 1
-      redirect_to [:admin, @object], alert: t('admin.move.permission_denied')
-    end
-  end
 
   def load_object
     # resource is inherited from localizable concern, only working because "movable" object are also localizable. 
     # If we want to use this concern for non-localizable objects, we would need to define a method to load the object instead of relying on resource.
     @object = resource
   end
 
+  def load_target_websites
+    @target_websites = current_user.managed_websites
+                                   .where(university_id: @object.university_id)
+                                   .where.not(id: @object.communication_website_id)
+  end
+  
+  def ensure_access
+    unless can?(:move, @object) && @target_websites.count > 0
+      redirect_to [:admin, @object], alert: t('admin.move.permission_denied')
+    end
+  end
+
 end

app/models/communication/website/post.rb

@@ -126,8 +126,5 @@ def update_authors_status_if_necessary!
   def list_blocks_template_kind
     :posts
   end
-
-  def after_moved_to_website(source_website, target_website)
-    authors.clear if source_website.university_id != target_website.university_id
-  end
+  
 end

app/models/concerns/movable_to_website.rb

@@ -1,10 +1,12 @@
 module MovableToWebsite
   extend ActiveSupport::Concern
 
+  # NOTE: this method does not handle move across universities, as we currently don't have any use case for it. 
+  # If we need to support it in the future, we will need to update the method to also update the university_id of the object and its associations, and handle potential conflicts (e.g. slug) that may arise from the move.
   def move_to!(website)
     source_website = self.website
     transaction do
-      update(communication_website_id: website.id, university_id: website.university_id)
+      update(communication_website_id: website.id)
       clean_categories_after_move
       clean_content_federations_after_move
       move_localizations_to(website)
@@ -28,29 +30,15 @@ def clean_content_federations_after_move
 
   def move_localizations_to(website)
     localizations.each do |l10n|
-      l10n.update(communication_website_id: website.id, university_id: website.university_id)
-      move_featured_image(l10n, website)
+      l10n.update(communication_website_id: website.id)
       move_blocks(l10n, website)
     end
   end
 
-  def move_featured_image(l10n, website)
-    return unless l10n.respond_to?(:featured_image) && l10n.featured_image.attached?
-    return if l10n.featured_image.blob.university_id == website.university_id
-    blob = l10n.featured_image.blob
-    if blob.attachments.count > 1
-      # duplicate blob
-      ActiveStorage::Utils.duplicate(l10n.featured_image, l10n.featured_image)
-    else
-      blob.update(university_id: website.university_id)
-    end
-  end
-
   def move_blocks(l10n, website)
     return unless l10n.respond_to?(:blocks)
     l10n.blocks.ordered.each do |block|
-      block.update(communication_website_id: website.id, university_id: website.university_id)
-      # TODO: il faut aussi vérifier les attachments des blocks et les dupliquer si besoin, comme pour les featured_image.
+      block.update(communication_website_id: website.id)
     end
   end
 

app/views/admin/application/move/_list_sites.html.erb

@@ -9,12 +9,8 @@ do_move_path = "do_move_admin_#{class_path}_path"
 
 <p><%= t('admin.move.description') %></p>
 
-<% unless current_user.server_admin?%>
-  <%= render 'admin/application/move/list_sites', websites: current_user.managed_websites, do_move_path: do_move_path %>
-<% else %>
-  <% University.ordered.each do |university| %>
-    <% next if university.websites.empty? %>
-    <h2><%= university %></h2>
-    <%= render 'admin/application/move/list_sites', websites: university.websites, do_move_path: do_move_path %>
-  <% end %>
-<% end %>
+<ul>
+  <% @target_websites.ordered(current_language).each do |website| %>
+      <li><%= link_to website.to_s_in(current_language), send(do_move_path, @object, new_website_id: website.id), method: :post %></li>
+  <% end %>   
+</ul>