-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Description
- The
brewcommand should include packagescmake(which is kinda obvious, but still),boost-python3for 0.6.0 and also (for some absolutely wild reason)qt5.catch2too, if it is preferable not to build it from submodules. - antlr4 does build itself even if it is installed, though as far as I understand it's not a macOS-specific build issue
- The hardcoded
LIBCLANG_LLVM_CONFIG_EXECUTABLEwould not work on Apple Silicon Macs, because the default prefix ofbrewis changed to /opt/homebrew. Upon llvm's installation in brew, it is suggested to add llvm to path,export PATH="/opt/homebrew/opt/llvm/bin:$PATH", removing the need for this workaround. - Python version is hardcoded, at the moment macOS's version of Python is newer. It would be better to determine python's version the same way it happens with ${UNIX} platform
- That said, even if I'd change the definitions to use python3.9 from brew, for it to find PythonLibs I must use
-DPYTHON_LIBRARY=$(python3-config --prefix)/lib/libpython3.9.dylib -DPYTHON_INCLUDE_DIR=$(python3-config --prefix)/include/python3.9flag for CMake upon Makefiles generation. I am not aware of any suitable fix for this problem at the moment. - atm, using Qt5.15 from brew raises "error: "Qt requires a C++17 compiler", but
-std=c++14is hardcoded for both GNU and Clang compilers. It's probably better to leave this option for CMake to decide on, or, as an alternate workaround, update it to-std=c++17. - RocksDB doesn't link correctly unless we will require a CMake package with
find_package(RocksDB REQUIRED)
I know some of these issues have been resolved in 0.7.0 (partially because Python was removed as a dependency), but either way it's not clear when 0.7.0 will be released, so a lot of students with Macs will appreciate if 0.6.0 would get a fix ❤️
Metadata
Metadata
Assignees
Labels
No labels