Is not caching action reqs a good idea?

[timkelty]

By default, we don't cache action reqs:

upper/src/EventRegistrar.php

Line 65 in bd6cd34

$request->getIsActionRequest() ||

For example, we're using Sprig on a site, and we want the responses cached. While the responses are all GETs with query params, they all have Cache-Control: private, because they are action reqs.

I'm wondering why, and if this is necessary at all?

Seems like any action reqs that weren't cacheable would already be naturally, either by being a POST or having a set-cookie header triggered from a session_start();

[timkelty]

This was added here: #36

[timkelty]

#36 (comment) - I think this reasoning was flawed, in that those will initiate sessions and have a set-cookie in the response, and therefore should be already be un-cacheable.

Perhaps a safer change would be to check if the response has a Set-Cookie, and if so, set Cache-control: private?

[ostark]

hmm, I'll consider this!