HTTP client change

[hez]

Looking at changing out HTTPoison for a new HTTP client.

A few benefits/things to consider

• we'd like to move to something all elixir and away from the older erlang libs
• should support pooling
• should support streaming of chunked http responses (this is used in the bulk fetch now) quite possible we don't need this as the chunking in bulk fetch will probably go away
• it would be nice to simplify the auth setup

Some options:

• finch

  • supports chunked streaming!
  • simpler client
  • mint back end

• telsa

  • possible issues implementing rate limiting
  • mint back

• Req

  • GraphQL implemented at Add GraphQLQuery and GraphQLResponse #623
  • Streaming of responses

[codeadict]

Req might be another option. Its modern, minimal and batteries included. I can add support for it if that makes sense

[hez]

Req might be another option. Its modern, minimal and batteries included. I can add support for it if that makes sense

We are definitely interested in something else besides HTTPoison, I have been using Req a bunch and it is a solid option. I think the biggest hurdle might be the streamed requests that happen, not sure if Req can support that.

here is the one area that comes to mind

elixir-shopifyapi/lib/shopify_api/bulk/query.ex

Line 186 in 8ffb1ce

def stream_fetch!(url, token) when is_binary(url) do